search

gildas-lormeau / single-file-cli

CLI tool for saving a faithful copy of a complete web page in a single HTML file (based on SingleFile)
GNU Affero General Public License v3.0
539 stars 57 forks source link

Docker image architecture #65

Closed rutkai closed 3 months ago

rutkai commented 3 months ago

Hey,

I wanted to use the docker image from this repo and I needed to realize, that the most recent build is for arm only on Dockerhub: image

Is this intentional? I can see an old tag that is amd64. If you switched architecture, can I expect an official amd64 build or I should build it myself?

gildas-lormeau commented 3 months ago

Sorry, it was not intended, I've just pushed an image for amd64.

rutkai commented 3 months ago

Awesome, thanks!

rutkai commented 3 months ago

Sorry @gildas-lormeau, but one more thing: are you planning to update npmjs also? I noticed you created the version 2.0.0 but it is not there yet: https://www.npmjs.com/package/single-file-cli

gildas-lormeau commented 3 months ago

@rutkai I don't know. Since the new CLI relies on Deno (for the runtime), it will be less relevant. Note however that I can provide executable files now (see Releases page).

rutkai commented 3 months ago

@gildas-lormeau Deno seems to be using npm (through a CDN proxy, ESM) and I cannot depend on single-file-cli without you publishing it as a module. It doesn't support setting a dependency as a git repository.

More docs: https://docs.deno.com/runtime/manual/basics/import_maps

gildas-lormeau commented 3 months ago

The problem is that the new version on NPM wouln't be compatible with Node.js.

gildas-lormeau commented 3 months ago

I made the code compatible with Node. The version 2..x is now on NPM.