search

gildas-lormeau / single-file-cli

CLI tool for saving a faithful copy of a complete web page in a single HTML file (based on SingleFile)
GNU Affero General Public License v3.0
539 stars 57 forks source link

Homebrew #71

Open notDavid opened 3 months ago

notDavid commented 3 months ago

Hi there,

would be useful to be able to install / update via Homebrew.

Also convenient for people to track this issue to know when it's closed / implemented... :-)

Thank you!

AngelaDMerkel commented 3 months ago

This will probably have to be a cask as building from source requires Deno. I will see if I can get this working, but I am having an error I have never seen before

gildas-lormeau commented 3 months ago

@AngelaDMerkel Thank you very much. I've never released sofware on Homebrew (and co.). Your help would be really precious. Don't hesitate to ping me if you need any help from me.

AngelaDMerkel commented 3 months ago

@gildas-lormeau I have no clue what I am doing either and their documentation is pretty poor from my point of view. You can see the pull request here if you want to check on its progress. It looks like it has passed most of the checks.

AngelaDMerkel commented 3 months ago

@gildas-lormeau Instead of using your precompiled binaries brew has asked me to write a small ruby package definition, which I have done and it successfully builds the single-file binary, but it appears that this binary still depends on single-file-launcher.js which doesn't get moved to homebrew's bin. Am I making a mistake in the compile process, or is it normal that building with Deno results in the need for these secondary files?

gildas-lormeau commented 2 months ago

@AngelaDMerkel That's strange. Could you give me a link to the related code? By the way, thank you again for your work, I read the thread but was a bit overwhelmed by the terms, not being used to homebrew and its ecosystem.

AngelaDMerkel commented 2 months ago

@gildas-lormeau I've resolved it now, and all the build and run test are passing in my PR https://github.com/Homebrew/homebrew-core/pull/168436

I am not sure they will merge given that I always fail their commit style test. I have no clue what I am doing incorrectly, but hopefully someone will just approve it and it'll be merged

gildas-lormeau commented 2 months ago

@AngelaDMerkel That's a great news :) Did you try to add an explanation for the commit as documented here https://docs.brew.sh/Formula-Cookbook#commit ? The complete commit message could be be for example:

single-file 2.0.29 (new formula)

adds formula for single-file CLI tool