search

gildas-lormeau / single-file-cli

CLI tool for saving a faithful copy of a complete web page in a single HTML file (based on SingleFile)
GNU Affero General Public License v3.0
539 stars 57 forks source link

added browser mobile emulation option with android device by default #90

Closed ym-rgalimov closed 1 month ago

ym-rgalimov commented 1 month ago

This PR is created to resolve issue #89.

It allows to use mobileEmulation mode when Chrome pretends to be a mobile device. Be default it sets as Android device with hardcoded resolution.

This is straightforward solution which works fine for me. I personally don't think users need much customisation such as providing platform or user agent.

gildas-lormeau commented 1 month ago

Thank you! I had to remove as most as possible the hard-coded values, so I implemented the feature. I think the current implementation should be OK. Let me know if you see anything wrong.

ym-rgalimov commented 1 month ago

Your change is much better. Thanks for the quick fix!

gildas-lormeau commented 1 month ago

Thank you very much for the feedback :)