gildas-lormeau / single-file-cli

CLI tool for saving a faithful copy of a complete web page in a single HTML file (based on SingleFile)
GNU Affero General Public License v3.0
539 stars 57 forks source link

Align --browser-server argument naming with its expected usage #94

Closed m3nadav closed 1 month ago

m3nadav commented 1 month ago

Trying to run the Single File CLI against an external browser lead me to finding this issue: browserRemoteDebuggingURL is not configured as a possible argument in the CLI, and by the current translation from argument name to and attribute of options it could never be named with capital URL On the other hand, the browserServer was defined as an argument but wasn't being used anywhere in the code

I might have misunderstood the intentions of the two attributes/arguments and the differences between them but thought I'd suggest this fix to allow others to use external browsers

Solves #93