gildas-lormeau / zip.js

JavaScript library to zip and unzip files supporting multi-core compression, compression streams, zip64, split files and encryption.
https://gildas-lormeau.github.io/zip.js
BSD 3-Clause "New" or "Revised" License
3.38k stars 510 forks source link

make getData always available in Entry #377

Closed hornta closed 1 year ago

hornta commented 1 year ago

I'm pretty sure the getData method is always available in the Entry object after reading the code so this change will reflect that in the typings.

gildas-lormeau commented 1 year ago

That's not the case, see https://github.com/gildas-lormeau/zip.js/issues/371. I will create 2 separate interfaces because it seems to confuse TS developers.

gildas-lormeau commented 1 year ago

It's fixed in the version 2.6.51 that I just published. Thank you!