search

gildas-lormeau / zip.js

JavaScript library to zip and unzip files supporting multi-core compression, compression streams, zip64, split files and encryption.
https://gildas-lormeau.github.io/zip.js
BSD 3-Clause "New" or "Revised" License
3.38k stars 510 forks source link

Error while type checking with dnt #382

Closed gauthier-th closed 1 year ago

gauthier-th commented 1 year ago

Hi, thanks for this great library 😉 I'm trying to build my Deno project to publish it on NPM, but i have the following error during the type checking of dnt:

src/deps/deno.land/x/zipjs@v2.6.57/lib/core/streams/codecs/sjcl.js:53:1 - error TS9005: Declaration emit for this file requires using private name 'sha1'. An explicit type annotation may unblock declaration emit.

Do you have any idea to solve this issue?

gildas-lormeau commented 1 year ago

I don't know what dnt is. However I suspect this issue is related to the fact that a class was not ported into the ES6 syntax. The last version that I've just published fixes this issue. Can you tell me if it's OK on your end?

Edit: For the record, "dnt" is "deno to node", see https://deno.land/manual@v1.26.0/node/dnt

gauthier-th commented 1 year ago

Yep, no more error, thanks!

gildas-lormeau commented 1 year ago

You're welcome :)