search

gildlab / ethgild

MIT License
2 stars 3 forks source link

For OffchainAssetVault, add a new event for each deposit/withdraw that includes the info in Deposit/Withdraw event + the receipt info + the receipt id #19

Closed hardyjosh closed 1 year ago

hardyjosh commented 1 year ago

The subgraph is unable to link events emitted as a result of the same deposit or withdraw.

The Deposit has information on the sender and the # of shares minted, but there's no way to know the associated ReceiptInformation and TransferSingle (includes the 1155 id) events.

You could say "consider all events emitted in the same transaction to be linked", but consider the edge case where a wrapping contract could call deposit twice in the same transaction.

thedavidmeister commented 1 year ago

this was done with DepositWithReceipt and WithdrawWithReceipt but withdraw only has receipt id there's no additional information on the asset being burned