search

gildor478 / ocaml-gettext

Other
13 stars 10 forks source link

--disable-camomile should not break stuff #14

Open gildor478 opened 4 years ago

gildor478 commented 4 years ago

This bug has been migrated from artifact #508 on forge.ocamlcore.org. It was assigned to user102.

user209 posted on 2010-01-12 10:46:06:

We don't need the camomile functionality in ocaml-gettext and so we routinely use:

./configure --disable-camomile

However this has many unnecessary side effects, in particular it breaks 'make' (in the doc directory), and tests.

(Hint, try building like this with and without camomile actually installed).

user209 replied on 2010-01-12 10:52:27:

Sorry, I don't mean in the doc directory, I mean both times it breaks in the test directory.

rwmjones commented 3 years ago

FWIW we're using this "hack" in Fedora to make ocaml-camomile into an optional dependency (because we want it in Fedora but not in RHEL): https://src.fedoraproject.org/rpms/ocaml-gettext/c/ab4b47dc0def66aa6635af2ad70cc7dc3d8e827e?branch=f34

rwmjones commented 3 years ago

In case that's not clear, the hack is:

%if %{without camomile}
# Remove dependency on camomile.
rm -r src/lib/gettext-camomile
rm -r test/test-camomile
sed -i -e 's/camomile//' `find -name dune`
%endif