gildor478 / ocaml-gettext

Other
13 stars 10 forks source link

Compatibility with OCaml5 #25

Closed mseri closed 1 year ago

mseri commented 1 year ago

Due to a bug on ounit2, already fixed upstream, this can only be tested by pinning to the current ounit master branch. Once that is released this package should be good to go.

There is a failure in the tests:

File "test/dune", line 2, characters 7-11:
2 |  (name test)
           ^^^^
............................................................................................................................................................F........
==============================================================================
Error: Test ocaml-gettext:6:POT/PO file merge test:0:test4.pot+test4.po:0:Merging.

File "/Users/mseri/code/ocaml/ocaml-gettext/_build/default/test/oUnit-Test ocaml-gettext-SURFnet-CIDR-90-145-invalid#00.log", line 629, characters 1-1:
Error: Test ocaml-gettext:6:POT/PO file merge test:0:test4.pot+test4.po:0:Merging (in the log).

Raised at OUnitAssert.assert_failure in file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 2-27
Called from OUnitRunner.run_one_test.(fun) in file "src/lib/ounit2/advanced/oUnitRunner.ml", line 83, characters 13-26

Unexpected error while processing testdata/test4.po ( OUnitTest.OUnit_failure("testdata/test4.po differs from testdata/test4.po.bak") )
------------------------------------------------------------------------------
Ran: 165 tests in: 0.15 seconds.
FAILED: Cases: 165 Tried: 165 Errors: 0 Failures: 1 Skip:  0 Todo: 0 Timeouts: 0.

However looking at the logs I cannot see the issue and diff testdata/test4.po testdata/test4.po.bak is empty.

Signed-off-by: Marcello Seri marcello.seri@gmail.com

mseri commented 1 year ago

Didn't notice #24 🤦

Leonidas-from-XIV commented 1 year ago

@mseri Shocking how similar the PRs turned out to be :smile: