gilesknap / gphotos-sync

Google Photos and Albums backup with Google Photos Library API
Apache License 2.0
2.03k stars 167 forks source link

OSError: [Errno 36] File name too long #256

Closed tarasglek closed 2 years ago

tarasglek commented 4 years ago

Describe the bug Was syncing my library for first time got this error.

To Reproduce Process failed. Traceback (most recent call last): File "/home/taras/.local/share/virtualenvs/gphotos-sync-Grs4-dzk/lib/python3.8/site-packages/gphotos/Main.py", line 418, in main self.start(args) File "/home/taras/.local/share/virtualenvs/gphotos-sync-Grs4-dzk/lib/python3.8/site-packages/gphotos/Main.py", line 369, in start self.do_sync(args) File "/home/taras/.local/share/virtualenvs/gphotos-sync-Grs4-dzk/lib/python3.8/site-packages/gphotos/Main.py", line 358, in do_sync self.google_albums_sync.create_album_content_links() File "/home/taras/.local/share/virtualenvs/gphotos-sync-Grs4-dzk/lib/python3.8/site-packages/gphotos/GoogleAlbumsSync.py", line 297, in create_album_content_links if not link_folder.is_dir(): File "/usr/lib/python3.8/pathlib.py", line 1398, in is_dir return S_ISDIR(self.stat().st_mode) File "/usr/lib/python3.8/pathlib.py", line 1189, in stat return self._accessor.stat(self) OSError: [Errno 36] File name too long: "/photos/XXXXXX@gmail.com/albums/2018/0214 Last day in Park City. Didn't beat the high score of 15300 vertical feet yesterday. Made it to 12600 since there was a leg bruising fall for Bobi on some difficult terrain. The cocoa is on her chest to help her costrocondritis (cartilage inflammation). She loved it as she watched Olympics on tv."

tarasglek commented 4 years ago

Looks like it's due to ZFS 256 char limit

tarasglek commented 4 years ago

Looks like --max-filename 150 does not apply to that particular stat call :(

gilesknap commented 4 years ago

This looks like two bugs. I should correctly discover the filename length for zfs and also honour max file length for all file system activity.

I'll take a look

On Mon, 10 Aug 2020, 02:03 Taras Glek, notifications@github.com wrote:

Looks like --max-filename 150 does not apply to that particular stat call :(

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/gilesknap/gphotos-sync/issues/256#issuecomment-671125673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHLRW4AZ5JDWY5IGQDB32LR75BNDANCNFSM4PZOFOEQ .

gilesknap commented 2 years ago

I'm releasing a new version of gphotos-sync and closing stale issues. Please reopen if you still want me to look at this. Thanks.