search

gilesknap / gphotos-sync

Google Photos and Albums backup with Google Photos Library API
Apache License 2.0
2.02k stars 165 forks source link

Add option to skip photos #392

Closed chisonne closed 1 year ago

chisonne commented 1 year ago

Users can use the --skip-photos option to donwload videos only.

gilesknap commented 1 year ago

Thanks for the PR.

I'll merge this but please can you add a caveat to the main readme to say gphotos-sync cannot do a perfect backup, particularly of videos and reference #119.

I can do the wording if you prefer but not for a couple of weeks.

chisonne commented 1 year ago

Hi Giles,

Will update the PR in a week or 2. Thanks for that information about the API issue. I was not aware of it.

Op zo 30 okt. 2022 08:42 schreef Giles Knap @.***>:

Thanks for the PR.

I'll merge this but please can you add a caveat to the main readme to say gphotos-sync cannot do a perfect backup, particularly of videos and reference #119 https://github.com/gilesknap/gphotos-sync/issues/119.

I can do the wording if you prefer but not for a couple of weeks.

— Reply to this email directly, view it on GitHub https://github.com/gilesknap/gphotos-sync/pull/392#issuecomment-1296152596, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADIHL5LIIH27DEXCLHT3DBLWFYKG7ANCNFSM6AAAAAARJPPT74 . You are receiving this because you authored the thread.Message ID: @.***>

gilesknap commented 1 year ago

I got around to updating the readme so will merge this.

I have to consolidate some of the container work and make another release sometime this month so your changes will release with that.

gilesknap commented 1 year ago

@chisonne I'm afraid you have broken some of the tests.

For details of how to run the tests locally and make a compliant contribution see https://github.com/gilesknap/gphotos-sync/blob/main/CONTRIBUTING.rst

Thanks, giles.

gilesknap commented 1 year ago

I'm going to close this due to lack of response and because of #119 Feel free to reopen if you still want to work on it.