gilesknap / gphotos-sync

Google Photos and Albums backup with Google Photos Library API
Apache License 2.0
1.97k stars 161 forks source link

ghcr.io/gilesknap/gphotos-sync container seems limited #410

Closed brianmiller closed 1 year ago

brianmiller commented 1 year ago

I may be doing something wrong. I followed the docs:

#!/bin/bash

CONFIG="/mnt/cerebrum/media/Photos/MyGooglePhotos/config"
STORAGE="/mnt/cerebrum/media/Photos/MyGooglePhotos/storage"

podman run --rm -v $CONFIG:/config -v $STORAGE:/storage -p 8080:8080 -it ghcr.io/gilesknap/gphotos-sync /storage

This syncs all of my photos+videos to $STORAGE, which is great, but when I run it a second time it gives me:

OSError: [Errno 39] Directory not empty: '/storage/.gphotos_check'

A few questions:

So far, fantastic tool! I'm super pleased to see more people are looking for these options and talented devs are willing to put the time in.

gilesknap commented 1 year ago

Hi @brianmiller your result is unexpected. Please can you post the whole error if there is any more to it? I don't have any guesses as to the issue right now.

gilesknap commented 1 year ago

Digging a bit, my guess is that for some reason the removal of the filesystem check folder is failing silently here: https://github.com/gilesknap/gphotos-sync/blob/61f0a8f2456ac0a47ce532dccbbe60ed3f6bfdc5/src/gphotos_sync/Checks.py#L117

So the next run it blows up.

What filesystem is your /mnt/cerebrum/media/Photos/MyGooglePhotos/storage ?

brianmiller commented 1 year ago

Thanks for the reply. /mnt/cerebrum/media/Photos/MyGooglePhotos/storage is an NFS export on top of XFS via Unraid.

If I wait a few minutes, .gphotos_check disappears by itself and runs fine. It must be related to NFS sync--maybe exporting with 'sync' instead of 'async' will fix this. I'll poke around.

gilesknap commented 1 year ago

I'm closing this as an issue with your filesystem please reopen if you think there are bugs that need addressing.