search

gilesknap / gphotos-sync

Google Photos and Albums backup with Google Photos Library API
Apache License 2.0
1.97k stars 161 forks source link

Support PUID and PGID environment variables #423

Open IslandJohn opened 1 year ago

IslandJohn commented 1 year ago

Many Docker containers allow setting the PUID and PGID environment variables so that the entry points shed their default 0:0 permissions. The gphotos-sync container setup currently ignores these. Please consider adding support for them.

gilesknap commented 1 year ago

Hi @IslandJohn

If I understand the use of these correctly then I believe we already have a solution for this. Take a look at this and see if it meets your requirement https://github.com/gilesknap/gphotos-sync/issues/279#issuecomment-1475317852

IslandJohn commented 1 year ago

Thanks, yes that's an option, it's just "less standard" on a Synology packing of Docker and I've been using env. vars where possible. Usually through the env vars the Dockerfile has adduser and shed the root permissions at startup.

gilesknap commented 1 year ago

Ok that sounds easy enough. I'll take a look soon.