gilesknap / mciwb

Minecraft Interactive world builder
Apache License 2.0
298 stars 6 forks source link

Thread Local Storage #19

Closed gilesknap closed 2 years ago

gilesknap commented 2 years ago

Major refactor use TLS for each thread to have its own RCON client.

This enables easy switching between a True client an MockClient.

Therefore, have begun a set of unit tests that use MockClient.

codecov[bot] commented 2 years ago

Codecov Report

Merging #19 (8399c66) into main (418d98d) will increase coverage by 3.77%. The diff coverage is 91.01%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   70.92%   74.70%   +3.77%     
==========================================
  Files           8        9       +1     
  Lines         399      419      +20     
==========================================
+ Hits          283      313      +30     
+ Misses        116      106      -10     
Impacted Files Coverage Δ
src/mciwb/signs.py 72.00% <81.25%> (+27.55%) :arrow_up:
src/mciwb/player.py 76.47% <85.71%> (-2.78%) :arrow_down:
src/mciwb/iwb.py 77.77% <89.47%> (+1.41%) :arrow_up:
src/mciwb/copier.py 51.35% <91.66%> (-1.90%) :arrow_down:
src/mciwb/backup.py 81.25% <100.00%> (-0.29%) :arrow_down:
src/mciwb/monitor.py 81.81% <100.00%> (+0.96%) :arrow_up:
src/mciwb/threads.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 418d98d...8399c66. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.0% 91.0% Coverage
0.0% 0.0% Duplication