gilesknap / mciwb

Minecraft Interactive world builder
Apache License 2.0
298 stars 6 forks source link

tidy #25

Closed gilesknap closed 2 years ago

gilesknap commented 2 years ago

Fixes for #24 amd #15 More test coverage Tidy public properties on interface classes switch to codacy only (drop sonarcloud and codecov)

codecov[bot] commented 2 years ago

Codecov Report

Merging #25 (22320a8) into main (db4cbae) will increase coverage by 6.41%. The diff coverage is 92.75%.

:exclamation: Current head 22320a8 differs from pull request most recent head b905354. Consider uploading reports for the commit b905354 to get more accurate results

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   82.11%   88.52%   +6.41%     
==========================================
  Files           9        9              
  Lines         436      453      +17     
==========================================
+ Hits          358      401      +43     
+ Misses         78       52      -26     
Impacted Files Coverage Δ
src/mciwb/monitor.py 81.15% <77.77%> (-4.30%) :arrow_down:
src/mciwb/player.py 92.59% <90.00%> (+15.23%) :arrow_up:
src/mciwb/copier.py 90.41% <100.00%> (ø)
src/mciwb/iwb.py 96.92% <100.00%> (+18.79%) :arrow_up:
src/mciwb/signs.py 94.11% <100.00%> (+22.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db4cbae...b905354. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

88.9% 88.9% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.1% 92.1% Coverage
0.0% 0.0% Duplication