gilesknap / mciwb

Minecraft Interactive world builder
Apache License 2.0
298 stars 6 forks source link

Action signs blank by default? #78

Closed ulrikpedersen closed 1 year ago

ulrikpedersen commented 1 year ago

The action signs don’t have the action written on the sign - so when placing one it pops up a screen where you can then type in “select” for example. The function does work but in the demo video it seems the action command is already written on the sign so placing it is much quicker because it doesn’t require typing each time… Bug 🐞 or feature? 😄

gilesknap commented 1 year ago

that's a bug for sure.

it should work because the CI tests it!

I'll take a look tomorrow.

compX44 commented 1 year ago

Hello. I am experiencing the same issue with the signs and I can't see the sand blocks being added when I followed the instructions.

gilesknap commented 1 year ago

@compX44 @ulrikpedersen I just had a go at reproducing this and failed to do so.

@compX44 which OS are you using please? (I'm on Linux and Ulrik is on Mac)

One other difference for me is I'm running against a remote Minecraft server and that is because my docker installation on my workstation is broken. I'll get it fixed and try mciwb's own minecraft server to see if that is where the issue lies.

gilesknap commented 1 year ago

I've now got a fresh server working using

mciwb start

It still does not show the issue that you both are seeing.

We need to work out what is different between our setups.

compX44 commented 1 year ago

@gilesknap I'm on Windows. I'm using the WSL2 Ubuntu on Docker from the setup instructions.

Also, I tried to destroy the item blocks that I put down, but they don't disappear. I keep on hitting the item and they make the sounds that means that they've been destroyed, but they don't disappear.

ulrikpedersen commented 1 year ago

Here is my environment:


I notice in the server logs that there are a lot of errors from chown... Looks like it is trying to use chown to change ownerships in /data/ but get Permission denied.

mini:~ ulrik$ docker logs mciwb-server
[init] Changing ownership of /data to 1000 ...
chown: changing ownership of '/data/server.properties': Permission denied
chown: changing ownership of '/data/whitelist.json': Permission denied
chown: changing ownership of '/data/versions/1.19.3/server-1.19.3.jar': Permission denied
chown: changing ownership of '/data/versions/1.19.3': Permission denied
chown: changing ownership of '/data/versions': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna/jna/5.12.1/jna-5.12.1.jar': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna/jna/5.12.1': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna/jna': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna/jna-platform/5.12.1/jna-platform-5.12.1.jar': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna/jna-platform/5.12.1': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna/jna-platform': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev/jna': Permission denied
chown: changing ownership of '/data/libraries/net/java/dev': Permission denied
chown: changing ownership of '/data/libraries/net/java': Permission denied
chown: changing ownership of '/data/libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar': Permission denied
chown: changing ownership of '/data/libraries/net/sf/jopt-simple/jopt-simple/5.0.4': Permission denied
chown: changing ownership of '/data/libraries/net/sf/jopt-simple/jopt-simple': Permission denied
chown: changing ownership of '/data/libraries/net/sf/jopt-simple': Permission denied
chown: changing ownership of '/data/libraries/net/sf': Permission denied
chown: changing ownership of '/data/libraries/net': Permission denied
chown: changing ownership of '/data/libraries/org/slf4j/slf4j-api/2.0.1/slf4j-api-2.0.1.jar': Permission denied
chown: changing ownership of '/data/libraries/org/slf4j/slf4j-api/2.0.1': Permission denied
chown: changing ownership of '/data/libraries/org/slf4j/slf4j-api': Permission denied
chown: changing ownership of '/data/libraries/org/slf4j': Permission denied
chown: changing ownership of '/data/libraries/org/joml/joml/1.10.5/joml-1.10.5.jar': Permission denied
chown: changing ownership of '/data/libraries/org/joml/joml/1.10.5': Permission denied
chown: changing ownership of '/data/libraries/org/joml/joml': Permission denied
chown: changing ownership of '/data/libraries/org/joml': Permission denied
chown: changing ownership of '/data/libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar': Permission denied
chown: changing ownership of '/data/libraries/org/apache/commons/commons-lang3/3.12.0': Permission denied
chown: changing ownership of '/data/libraries/org/apache/commons/commons-lang3': Permission denied
chown: changing ownership of '/data/libraries/org/apache/commons': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-slf4j2-impl/2.19.0/log4j-slf4j2-impl-2.19.0.jar': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-slf4j2-impl/2.19.0': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-slf4j2-impl': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-api/2.19.0/log4j-api-2.19.0.jar': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-api/2.19.0': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-api': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-core/2.19.0': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j/log4j-core': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging/log4j': Permission denied
chown: changing ownership of '/data/libraries/org/apache/logging': Permission denied
chown: changing ownership of '/data/libraries/org/apache': Permission denied
chown: changing ownership of '/data/libraries/org': Permission denied
chown: changing ownership of '/data/libraries/it/unimi/dsi/fastutil/8.5.9/fastutil-8.5.9.jar': Permission denied
chown: changing ownership of '/data/libraries/it/unimi/dsi/fastutil/8.5.9': Permission denied
chown: changing ownership of '/data/libraries/it/unimi/dsi/fastutil': Permission denied
chown: changing ownership of '/data/libraries/it/unimi/dsi': Permission denied
chown: changing ownership of '/data/libraries/it/unimi': Permission denied
chown: changing ownership of '/data/libraries/it': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-handler/4.1.82.Final/netty-handler-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-handler/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-handler': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-codec/4.1.82.Final/netty-codec-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-codec/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-codec': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-classes-epoll/4.1.82.Final/netty-transport-classes-epoll-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-classes-epoll/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-classes-epoll': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-common/4.1.82.Final/netty-common-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-common/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-common': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-epoll/4.1.82.Final/netty-transport-native-epoll-4.1.82.Final-linux-aarch_64.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-epoll/4.1.82.Final/netty-transport-native-epoll-4.1.82.Final-linux-x86_64.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-epoll/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-epoll': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-resolver/4.1.82.Final/netty-resolver-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-resolver/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-resolver': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport/4.1.82.Final/netty-transport-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-unix-common/4.1.82.Final/netty-transport-native-unix-common-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-unix-common/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-transport-native-unix-common': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-buffer/4.1.82.Final/netty-buffer-4.1.82.Final.jar': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-buffer/4.1.82.Final': Permission denied
chown: changing ownership of '/data/libraries/io/netty/netty-buffer': Permission denied
chown: changing ownership of '/data/libraries/io/netty': Permission denied
chown: changing ownership of '/data/libraries/io': Permission denied
chown: changing ownership of '/data/libraries/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar': Permission denied
chown: changing ownership of '/data/libraries/commons-io/commons-io/2.11.0': Permission denied
chown: changing ownership of '/data/libraries/commons-io/commons-io': Permission denied
chown: changing ownership of '/data/libraries/commons-io': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava/guava/31.1-jre/guava-31.1-jre.jar': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava/guava/31.1-jre': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava/guava': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava/failureaccess/1.0.1': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava/failureaccess': Permission denied
chown: changing ownership of '/data/libraries/com/google/guava': Permission denied
chown: changing ownership of '/data/libraries/com/google/code/gson/gson/2.10/gson-2.10.jar': Permission denied
chown: changing ownership of '/data/libraries/com/google/code/gson/gson/2.10': Permission denied
chown: changing ownership of '/data/libraries/com/google/code/gson/gson': Permission denied
chown: changing ownership of '/data/libraries/com/google/code/gson': Permission denied
chown: changing ownership of '/data/libraries/com/google/code': Permission denied
chown: changing ownership of '/data/libraries/com/google': Permission denied
chown: changing ownership of '/data/libraries/com/github/oshi/oshi-core/6.2.2/oshi-core-6.2.2.jar': Permission denied
chown: changing ownership of '/data/libraries/com/github/oshi/oshi-core/6.2.2': Permission denied
chown: changing ownership of '/data/libraries/com/github/oshi/oshi-core': Permission denied
chown: changing ownership of '/data/libraries/com/github/oshi': Permission denied
chown: changing ownership of '/data/libraries/com/github': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/brigadier/1.0.18/brigadier-1.0.18.jar': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/brigadier/1.0.18': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/brigadier': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/datafixerupper/5.0.28/datafixerupper-5.0.28.jar': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/datafixerupper/5.0.28': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/datafixerupper': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/authlib/3.16.29/authlib-3.16.29.jar': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/authlib/3.16.29': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/authlib': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/javabridge/2.0.25/javabridge-2.0.25.jar': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/javabridge/2.0.25': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/javabridge': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/logging/1.1.1/logging-1.1.1.jar': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/logging/1.1.1': Permission denied
chown: changing ownership of '/data/libraries/com/mojang/logging': Permission denied
chown: changing ownership of '/data/libraries/com/mojang': Permission denied
chown: changing ownership of '/data/libraries/com': Permission denied
chown: changing ownership of '/data/libraries': Permission denied
chown: changing ownership of '/data/world/level.dat_old': Permission denied
chown: changing ownership of '/data/world/advancements/b68fd9af-2eab-467b-a053-48e318c1cba6.json': Permission denied
chown: changing ownership of '/data/world/advancements': Permission denied
chown: changing ownership of '/data/world/playerdata/b68fd9af-2eab-467b-a053-48e318c1cba6.dat_old': Permission denied
chown: changing ownership of '/data/world/playerdata/b68fd9af-2eab-467b-a053-48e318c1cba6.dat': Permission denied
chown: changing ownership of '/data/world/playerdata': Permission denied
chown: changing ownership of '/data/world/poi/r.0.-4.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.-1.0.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.0.-1.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.0.-3.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.0.0.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.1.-4.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.-1.-1.mca': Permission denied
chown: changing ownership of '/data/world/poi/r.1.-3.mca': Permission denied
chown: changing ownership of '/data/world/poi': Permission denied
chown: changing ownership of '/data/world/DIM-1/data/raids.dat': Permission denied
chown: changing ownership of '/data/world/DIM-1/data': Permission denied
chown: changing ownership of '/data/world/DIM-1': Permission denied
chown: changing ownership of '/data/world/region/r.2.-3.mca': Permission denied
chown: changing ownership of '/data/world/region/r.0.-4.mca': Permission denied
chown: changing ownership of '/data/world/region/r.-1.0.mca': Permission denied
chown: changing ownership of '/data/world/region/r.0.-1.mca': Permission denied
chown: changing ownership of '/data/world/region/r.2.-4.mca': Permission denied
chown: changing ownership of '/data/world/region/r.0.-3.mca': Permission denied
chown: changing ownership of '/data/world/region/r.0.0.mca': Permission denied
chown: changing ownership of '/data/world/region/r.1.-4.mca': Permission denied
chown: changing ownership of '/data/world/region/r.-1.-1.mca': Permission denied
chown: changing ownership of '/data/world/region/r.1.-3.mca': Permission denied
chown: changing ownership of '/data/world/region': Permission denied
chown: changing ownership of '/data/world/DIM1/data/raids_end.dat': Permission denied
chown: changing ownership of '/data/world/DIM1/data': Permission denied
chown: changing ownership of '/data/world/DIM1': Permission denied
chown: changing ownership of '/data/world/level.dat': Permission denied
chown: changing ownership of '/data/world/session.lock': Permission denied
chown: changing ownership of '/data/world/data/raids.dat': Permission denied
chown: changing ownership of '/data/world/data/chunks.dat': Permission denied
chown: changing ownership of '/data/world/data': Permission denied
chown: changing ownership of '/data/world/stats/b68fd9af-2eab-467b-a053-48e318c1cba6.json': Permission denied
chown: changing ownership of '/data/world/stats': Permission denied
chown: changing ownership of '/data/world/entities/r.0.-4.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.-1.0.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.0.-1.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.0.-3.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.0.0.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.1.-4.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.-1.-1.mca': Permission denied
chown: changing ownership of '/data/world/entities/r.1.-3.mca': Permission denied
chown: changing ownership of '/data/world/entities': Permission denied
chown: changing ownership of '/data/world/datapacks': Permission denied
chown: changing ownership of '/data/world': Permission denied
chown: changing ownership of '/data/banned-players.json': Permission denied
chown: changing ownership of '/data/logs/latest.log': Permission denied
chown: changing ownership of '/data/logs/2023-03-11-2.log.gz': Permission denied
chown: changing ownership of '/data/logs/2023-03-12-1.log.gz': Permission denied
chown: changing ownership of '/data/logs/2023-03-11-1.log.gz': Permission denied
chown: changing ownership of '/data/logs': Permission denied
chown: changing ownership of '/data/minecraft_server.1.19.3.jar': Permission denied
chown: changing ownership of '/data/usercache.json': Permission denied
chown: changing ownership of '/data/banned-ips.json': Permission denied
chown: changing ownership of '/data/eula.txt': Permission denied
chown: changing ownership of '/data/.cache/JNA/temp': Permission denied
chown: changing ownership of '/data/.cache/JNA': Permission denied
chown: changing ownership of '/data/.cache': Permission denied
chown: changing ownership of '/data/ops.json': Permission denied
chown: changing ownership of '/data': Permission denied
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x 1 501 20 480 Mar 12 16:27 /data'
[init] Resolved version given LATEST into 1.19.3 and major version 1.19
[init] Resolving type given VANILLA
[init] Setting mode
[init] Updating ops
[init] TransformerScorn already present in ops.json, skipping
[init] Setting initial memory to 1G and max to 1G
[init] Starting the Minecraft server...
Starting net.minecraft.server.Main
[21:11:51] [ServerMain/INFO]: Building unoptimized datafixer
[21:11:52] [ServerMain/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[21:11:53] [ServerMain/INFO]: Loaded 7 recipes
[21:11:53] [ServerMain/INFO]: Loaded 1179 advancements
[21:11:53] [Server thread/INFO]: Starting minecraft server version 1.19.3
[21:11:53] [Server thread/INFO]: Loading properties
[21:11:53] [Server thread/INFO]: Default game type: CREATIVE
[21:11:53] [Server thread/INFO]: Generating keypair
[21:11:53] [Server thread/INFO]: Starting Minecraft server on *:20101
[21:11:53] [Server thread/INFO]: Using epoll channel type
[21:11:54] [Server thread/INFO]: Preparing level "world"
[21:11:55] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[21:11:57] [Worker-Main-2/INFO]: Preparing spawn area: 0%
[21:11:57] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[21:11:57] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[21:11:57] [Worker-Main-3/INFO]: Preparing spawn area: 0%
[21:11:57] [Worker-Main-2/INFO]: Preparing spawn area: 0%
[21:11:58] [Worker-Main-1/INFO]: Preparing spawn area: 0%
[21:11:58] [Worker-Main-1/INFO]: Preparing spawn area: 56%
[21:11:59] [Server thread/INFO]: Time elapsed: 3389 ms
[21:11:59] [Server thread/INFO]: Done (5.140s)! For help, type "help"
[21:11:59] [Server thread/INFO]: Starting remote control listener
[21:11:59] [Server thread/INFO]: Thread RCON Listener started
[21:11:59] [Server thread/INFO]: RCON running on 0.0.0.0:20100
[21:11:59] [RCON Listener #1/INFO]: Thread RCON Client /172.17.0.1 started
[21:11:59] [RCON Client /172.17.0.1 #2/INFO]: Thread RCON Client /172.17.0.1 shutting down
[21:11:59] [RCON Listener #1/INFO]: Thread RCON Client /172.17.0.1 started
[21:12:00] [Server thread/INFO]: [Rcon: Set the world spawn point to 632, 73, -1658 [0.0]]
[21:12:00] [RCON Client /172.17.0.1 #3/INFO]: Thread RCON Client /172.17.0.1 shutting down
[21:15:45] [Server thread/WARN]: handleDisconnection() called twice
[21:16:14] [RCON Listener #1/INFO]: Thread RCON Client /172.17.0.1 started
[21:16:14] [Server thread/INFO]: [Rcon: Gamerule sendCommandFeedback is now set to: false]
[21:16:14] [RCON Listener #1/INFO]: Thread RCON Client /172.17.0.1 started
[21:16:14] [RCON Client /172.17.0.1 #5/INFO]: Thread RCON Client /172.17.0.1 shutting down
[21:16:33] [RCON Client /172.17.0.1 #4/INFO]: Thread RCON Client /172.17.0.1 shutting down

(It also looks like "TransformerScorn" is in ops.json - developer remnant?)

gilesknap commented 1 year ago

@ulrikpedersen @compX44 please can you try this: In the game type /clear to remove all items from inventory. Then report the output of the following commands in mciwb ipython :

world.signs.give_signs()
world.player.inventory()

It should look somthing like this:

Out[3]: 'TransformerScorn has the following entity data: [{Slot: 0b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"select"}\'}, display: {Name: \'{"text":"select"}\'}}}, {Slot: 1b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"paste"}\'}, display: {Name: \'{"text":"paste"}\'}}}, {Slot: 2b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"expand"}\'}, display: {Name: \'{"text":"expand"}\'}}}, {Slot: 3b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"clear"}\'}, display: {Name: \'{"text":"clear"}\'}}}]'
gilesknap commented 1 year ago

@ulrikpedersen I'm not sure if the chown issues are benign or not - will look at this (having all sorts of issues with podman/docker differences and this is related )

TransformerScorn is my player and should not really be in ops.json .

gilesknap commented 1 year ago

@compX44 your symptoms of not being able to break blocks is weird. I thought maybe you were in adventure mode but I checked and there is no breaking sound in adventure mode. It is perhaps possible that the chown issue Ulrik reported is related.

Tomorrow I'll switch over to Windows and see if I can reproduce any of these issues. I at least have a working docker on my windows system!

ulrikpedersen commented 1 year ago

In the game type /clear to remove all items from inventory.

This just gives me an error 🤔

Unknown or incomplete command, see below for error
clear<--[HERE]

(so I threw away the signs with the q instead)

Then report the output of the following commands in mciwb ipython :

In [4]: world.signs.give_signs()

In [5]: world.player.inventory
Out[5]: 'AlbaDancer has the following entity data: [{Slot: 0b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"select"}\'}, display: {Name: \'{"text":"select"}\'}}}, {Slot: 1b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"paste"}\'}, display: {Name: \'{"text":"paste"}\'}}}, {Slot: 2b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"expand"}\'}, display: {Name: \'{"text":"expand"}\'}}}, {Slot: 3b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"clear"}\'}, display: {Name: \'{"text":"clear"}\'}}}]'

I'm not sure if the chown issues are benign or not - will look at this (having all sorts of issues with podman/docker differences and this is related )

I think I had a bit of a mess. I had tried to also run up your docker image - don't know if that had something to do with it(?) In any case, I deleted the mciwb-server folder and started over. That seems to have fixed that particular (chown error) issue.

However, the original issue that the signs don't have the text in them persists...

I think I ran into the block-not-mining issue that @compX44 mentioned:

Also, I tried to destroy the item blocks that I put down, but they don't disappear. I keep on hitting the item and they make the sounds that means that they've been destroyed, but they don't disappear.

This happens when I try to mine blocks (sand or whatever) in a zone a few (10ish?) blocks around the spawn point. In this zone I also can't place signs. Try to move 20-odd blocks away from spawn point before starting to play with the signs. Perhaps this is due to the spawn-protection=16 in server.properties?

Just to summarise: I think I've gone around in a circle and I'm now back and left with the original problem: action signs don't have pre-defined text in them. Phew 😆

ulrikpedersen commented 1 year ago

😃 AHA! Just in that one last attempt before I pass out tonight - I think I got it! 🎉

I stopped the server, went into ops.json and removed the user that was there and added my own. Then restarted the server with mciwb start connect client and shell and voila: signs now have the default text in them and works just like the video!

So it seems you have to have operator permissions for this to work (seamlessly)

compX44 commented 1 year ago

I'm on Windows 10, using Ubuntu with the WSL extension in Vscode with the docker container. I have Python 3.10 and IPython 8.10.0. I'm using the latest version of Minecraft (1.19.3). I have updated to the latest mciwb package.

I also got the unknown command error when I typed in /clear. So, I cleared out my inventory with Q as well.

I tried the command and got the following output:

In [1]: world.signs.give_signs()

In [2]: world.player.inventory Out[2]: 'Pyr0Blue has the following entity data: [{Slot: 0b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"select"}\'}, display: {Name: \'{"text":"select"}\'}}}, {Slot: 1b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"paste"}\'}, display: {Name: \'{"text":"paste"}\'}}}, {Slot: 2b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"expand"}\'}, display: {Name: \'{"text":"expand"}\'}}}, {Slot: 3b, id: "minecraft:oak_sign", Count: 1b, tag: {BlockEntityTag: {Text1: \'{"text":"clear"}\'}, display: {Name: \'{"text":"clear"}\'}}}]'

I went and removed the user in the ops.json file and replaced it with my own like @ulrikpedersen did and still couldn't get the same results as the demo video.

compX44 commented 1 year ago

I moved away from the spawn point as @ulrikpedersen suggested and had luck with the signs and mining there. I had to type on the signs though.

gilesknap commented 1 year ago

@ulrikpedersen that was a good experiment to do. It's odd since the python code uses rcon and should not be user related.

You are dead right about spawn protection. This stops anything building near to the spawn point. I thought I had that switched off.

@compX44 your inventory does indeed contains signs with the correct tags (name and Text1) so they should be working I'll do some more digging.

Thanks for all the useful feedback. I'll do more investigation after work this evening.

gilesknap commented 1 year ago

In the game type /clear to remove all items from inventory.

This just gives me an error

That's because you were not an operator - I should have thought of that. Although I did not think you need to be an operator to use mciwb it certainly helps to allow you to send operator commands in game.

gilesknap commented 1 year ago

@ulrikpedersen @compX44 I've just tried remvoing myself from ops and I can reproduce the blank sign issue.

So it seems like Ulrik has cracked it. Thanks!

I'll make an update to auto add you to ops when running mciwb shell --user XXX Note that being ops would also override spawn protection so this should fix everything.

Expect an update this evening.

gilesknap commented 1 year ago

OK I think #82 has fixed the issue.

I've tried it out on WSL2 as well and all seems well.

The new version 0.8.5 is released with this fix. Let me know if it works for you.

To properly test this you will want to delete your existing server before starting a new one

mciwb stop
rm -r $HOME/mciwb-server
mciwb start

But having said that, this should work against an existing server if you have made changes you want to keep.

@ulrikpedersen @compX44 thanks for your help with this. It's the kind of error that I would never notice with self testing only.

compX44 commented 1 year ago

@gilesknap I stopped the server and restarted it after updating the mciwb and I was able to achieve the same results as the demo video. Thank you so much for looking into this.

gilesknap commented 1 year ago

Awesome. Thanks for letting me know @compX44. Closing.

gilesknap commented 1 year ago

@compX44 @ulrikpedersen

Slightly cheeky request here. I'm having another go at promoting this project today. It would be nice to get a bit of a community going.

Maybe you would like to star this github repo? and or upvote this reddit https://www.reddit.com/r/Minecraftbuilds/comments/11rqauh/build_things_using_python/?utm_source=share&utm_medium=web2x&context=3

Thanks! (feel free to ignore)

ulrikpedersen commented 1 year ago

Checked now and it works out of the box for me too now 👍

⭐ ✔️ 💯

compX44 commented 1 year ago

I don't have a reddit account, but I did see your project there while I was looking something up. Having a community would be nice.