gilesvangruisen / Swift-YouTube-Player

Swift library for embedding and controlling YouTube videos in your iOS applications via WKWebView!
MIT License
874 stars 282 forks source link

Having issues updating to 0.7.0 via Carthage #200

Closed jianyaoang closed 4 years ago

jianyaoang commented 4 years ago

Thanks for the latest release 0.7.0

I tried installing it via Carthage, but am having issue:

*** Skipped building Swift-YouTube-Player due to the error:
Dependency "Swift-YouTube-Player" has no shared framework schemes for any of the platforms: iOS

If you believe this to be an error, please file an issue with the maintainers at https://github.com/gilesvangruisen/Swift-YouTube-Player/issues/new

Cartfile: github "gilesvangruisen/Swift-YouTube-Player"

gilesvangruisen commented 4 years ago

Hey @jianyaoang really sorry for the delay! Some things got shuffled around in the 0.7.0 and it looks like I mistakenly removed the xcshareddata which broke Carthage. I just pushed a v0.7.1, which should hopefully fix your issue.

Closing for now but please reopen and ping me if this continues to be a problem. Thanks!

jianyaoang commented 4 years ago

@gilesvangruisen Thanks for the 0.7.1 release. However, I am still facing the same issue. When i ran carthage update --platform iOS

*** Skipped building Swift-YouTube-Player due to the error:
Dependency "Swift-YouTube-Player" has no shared framework schemes for any of the platforms: iOS

If you believe this to be an error, please file an issue with the maintainers at https://github.com/gilesvangruisen/Swift-YouTube-Player/issues/new

Am using the latest Carthage version 0.35.0, and set it in my Cartfile as github "gilesvangruisen/Swift-YouTube-Player" == 0.7.1

Thank you!

gilesvangruisen commented 4 years ago

@jianyaoang shoot, I think you're right! I just pushed 0.7.2, which hopefully has fixed the shared scheme issue. Please let me know if that works, thanks!