search

gilfether / phpcrypt

A PHP Encryption Library API which does not use 3rd party libraries.
http://www.gilfether.com/phpcrypt
25 stars 18 forks source link

Composer #5

Open miladrahimi opened 9 years ago

miladrahimi commented 9 years ago

Your package was awesome. But you should update it, because it's unusable while it doesn't follow standards.

  1. Correct class names and namespaces, I offer these:
    • Rename PHP_Crypt to Crypt and so on.
    • Rename your namespace to Gilfether/PHPCrypt.
    • Put the classes into src/Gilfether/PHPCrypt directory.
    • Put README.md, licenses files, Example directories and files next to src directory.
    • I pulled composer.json but it's better to so it yourserf, make you package Composer-friendly! Thanks a lot.
gilfether commented 9 years ago

Thanks for the suggestions

I've been busy with work and havent had the time to update or work on php crypt like i want too recently. I'll try to find time soon to look at these changes and incorporate them

Thanks for helping make this a better package. I want it to be as user friendly and simple as possible for everyone. Feedback always helps me!

Ryan

Sent from my iPhone

On Jun 17, 2015, at 2:11 AM, Milad Rahimi notifications@github.com wrote:

Your package was awesome. But you should update it, because it's unusable while it doesn't follow standards.

  1. Correct class names and namespaces, I offer these:

Rename PHP_Crypt to Crypt and so on. Rename your namespace to Gilfether/PHPCrypt. Put the classes into src/Gilfether/PHPCrypt directory. Put README.md, licenses files, Example directories and files next to src directory. I pulled composer.json but it's better to so it yourserf, make you package Composer-friendly! Thanks a lot. — Reply to this email directly or view it on GitHub.

mattharley commented 5 years ago

Hey guys any update on this? Tried installing via composer and noticed it's not on there yet.

miladrahimi commented 5 years ago

@mattharley I've created my own package, you can use it. https://github.com/miladrahimi/phpcrypt Of course, it's archived now but it works, hope it helps you.

mattharley commented 5 years ago

Thank you!