search

gilgen / ember-pusher

A proper Ember / Pusher integration.
MIT License
99 stars 35 forks source link

Promises #33

Closed yratanov closed 8 years ago

yratanov commented 8 years ago

Hi,

1) What do you think about wrapping callbacks with promises? It causes test failures when I run them using ember test. And it is also a proper way of handling async stuff in Ember. 2) What do you think about checking if environment is testing and replacing real requests with stubs?

gilgen commented 8 years ago
  1. The callbacks are already hit with send() and not called directly.
  2. Which requests are you referring to?