search

gillchristian / tsplay.dev

TypeScript Playground Shortener
https://tsplay.dev
MIT License
69 stars 9 forks source link

Add `DiscordBot` option to `CreatedOn` #69

Closed tjjfvi closed 3 years ago

tjjfvi commented 3 years ago

Not sure if there's anywhere else this needs to be added; I didn't see anything on a quick search.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gillchristian/tsplay/6yLY5MVjXrzNka1qJPebv6DEFdAF
✅ Preview: https://tsplay-git-fork-tjjfvi-patch-1-gillchristian.vercel.app

gillchristian commented 3 years ago

Looks like there are issues with the GitHub Action that I need to fix.

A query needs to be added here:

https://github.com/gillchristian/tsplay.dev/blob/9cbefa1982e8899fc2795d39cb418e39ace248cc/server/src/Api/Short/Persistence.hs#L70-L78

And the table would need a new colum

https://github.com/gillchristian/tsplay.dev/blob/9cbefa1982e8899fc2795d39cb418e39ace248cc/server/database/migrations/00002.visited.sql#L8-L16

However I'm not liking this approach already, it doesn't make require a new column and a new query every time a new source is added. I will refactor it to a more future proof approach.

On the meantime you can keep "api" as the source in your PR to avoid being blocked by this. Or you could add the query and column and then I refactor that. Up to you.

tjjfvi commented 3 years ago

There's no rush on my end; it can stay as api for now 👍