search

gillescastel / inkscape-figures

Inkscape figure manager
MIT License
557 stars 119 forks source link

Support MacOS #11

Closed pierreglaser closed 4 years ago

pierreglaser commented 4 years ago

This PR aims to add support to MacOS. It includes:

Depending on what is considered public API, I may have introduced some breaking changes. The CLI interface did not change, but the internals yes, due to some refactoring.

I currently tested it on my MacBook, but not on a linux system -- I may have broken some things along the way. I am going to check this branch on a linux machine ASAP.

cc @gillescastel just in case.

pierreglaser commented 4 years ago

IIRC inotify is not supported on MacOS (I mentioned it in the original PR message). Have you pip install-ed the module? It should look for fswatch instead at installation step.

pierreglaser commented 4 years ago

Could you do python3 -m pip install -e path/to/inkscape-figures/ instead of pip3 setup.py install to install inkscape-figures? I can't reproduce your problem locally.

Also, you might want to check why you have a command not found: inkscape-figures error message by zsh.

pierreglaser commented 4 years ago

Thank you for taking the time to test this branch by the way!

pierreglaser commented 4 years ago

Ideally, you can first create a python virtual environment where you do solely an editable install of inkscape-figures:

python3 -m venv venv/
source venv/bin/activate
python3 -m pip install -e path/to/inkscape-figures

If you do this, you won't for sure have an inkscape-figures entry in your site-packages.

pierreglaser commented 4 years ago

Also, what command triggers this error? pip install -e? or a bash command triggered by a mapping in vim?

BerryTaylor commented 4 years ago

It did work perfectly! I will sort out the steps we figure out the problem later, if you have the same problem just see our conversations please!

gillescastel commented 4 years ago

Merging this! Thanks a lot for the pull request, @pierreglaser!

pierreglaser commented 4 years ago

No worries. I'll try to be responsive to issues opened here related to MacOS support. Do not hesitate to ping me @gillescastel .

BerryTaylor commented 4 years ago

Hi,@pierreglaser the Inkscape-figures watch command seems strange when I run the command, there is not any responses nor log and of course the svg can not be saved as pdf and pdf_tex automatically