SPTK-style plain binary input F0 for analysis

gillesdegottex / pulsemodel

Pulse Model vocoder

Apache License 2.0

41 stars 7 forks source link

Closed ljuvela closed 7 years ago

ljuvela commented 7 years ago

Added option to use binary input F0s that only contain F0 values at constant frame rate. This is the default format used in SPTK/HTS/Merlin.

From python analysis.py --help

 --inf0bin INF0BIN     Given f0 file (single precision float binary)

gillesdegottex commented 7 years ago

Good idea! Though, there is a set_trace left somewhere. Do you really want to add test/test_lauri.sh also ?

ljuvela commented 7 years ago

The set_trace commented out, but it shouldn't be there anyway.

My test script probably shouldn't go into the main repo either. It doesn't conform to your testing format and is a kind of specific use case.

Instead, it would be nice to write a test in test/Makefile

gillesdegottex commented 7 years ago

Would you thus update the pull request by committing the changes?

What do you mean by write a test in test/Makefile ?