gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.43k stars 123 forks source link

Search feature request #1

Open niftylettuce opened 9 years ago

niftylettuce commented 9 years ago

It'd be nice to be able to search for music, tags, genres, ...

seppestas commented 9 years ago

Do you mean a global search (on the entire souncloud), or the ability to search in a user's stream / playlists / likes?

Since this is a pretty minimal app, I think global search functionality is out of scope... However this has my +1 for search functionality in favorites.

niftylettuce commented 9 years ago

Global search On Jun 8, 2015 8:10 AM, "Seppe Stas" notifications@github.com wrote:

Do you mean a global search (on the entire souncloud), or the ability to search in a user's stream / playlists / likes?

Since this is a pretty minimal app, I think global search functionality is out of scope... However this has my +1 for search functionality in favorites.

— Reply to this email directly or view it on GitHub https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-109970349.

MichielDeMey commented 9 years ago

Hi @niftylettuce

Thanks for the feature request, however search is not currently on our roadmap since we feel that it is largely outside of the scope of this project.

That's not to say that we won't add it in the future. :)

niftylettuce commented 9 years ago

How can this be a music player if you can't search for music? SoundCloud's API is right there for us to use. So what, am I supposed to go to SoundCloud.com every time I want to add a new track to a playlist? What if I don't like anything that's in the Feed? What if I want to listen to a specific song someone told me about? That's bizarre to not have this feature...

niftylettuce commented 9 years ago

https://developers.soundcloud.com/docs/api/guide#search

gillesdemey commented 9 years ago

I think you will be better served by something like SoundNode, which is trying to be more than Cumulus is.

We've debated adding search, but it comes with a number of extra features we don't want to implement right now

We think Cumulus is a great companion for playing the music you've curated on SoundCloud, but doesn't aim to replace SoundClouds amazing web experience.

niftylettuce commented 9 years ago

Finish your feature for search and fork the project we can use your fork for cool stuff like this On Jun 9, 2015 3:17 PM, "Seppe Stas" notifications@github.com wrote:

But, but... I was just working on a search feature... [image: :confused:]

— Reply to this email directly or view it on GitHub https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-110470459.

arslion commented 8 years ago

It has to be there. most people want to listen to new songs as well, or from a specific artist/genre etc.

seppestas commented 8 years ago

We already looked into a search feature, but it's quite a lot of work. Mainly because it requires some pretty complex additions to the UI to make it work properly. Keeping things simple is one of the main goals of this app, if you want to have a complete Soundcloud experience there are plenty of alternatives available.

There are still a lot of things that need to be addressed before we should consider adding more features, and there are A LOT of features the Soundcloud API exposes that we could add to this app. Just throwing everything together into a complex, ugly UI is the opposite of what we are trying to accomplish.

niftylettuce commented 8 years ago

There's a lot of demand for this. Do you want people to use Cumulus or do you want them to use other terrible apps that aren't open source. On Nov 3, 2015 6:43 AM, "Seppe Stas" notifications@github.com wrote:

We already looked into a search feature, but it quite a lot of work. Mainly because it requires some pretty complex additions to the UI to make it work properly. Keeping things simple is one of the main goals of this app, if you want to have a complete Soundcloud experience there plenty of alternatives http://alternativeto.net/software/cumulus/ available.

There are still a lot of things that need to be addressed before we should consider adding more features, and there are A LOT of features the Soundcloud API exposes that we could add to this app. Just throwing everything together into a complex, ugly UI is the opposite of what we are trying to accomplish.

— Reply to this email directly or view it on GitHub https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-153327548.

MichielDeMey commented 8 years ago

Currently, this is nothing more than a weekend project that suddenly got a lot of attention.

The unfortunate reality is that all of our core contributors have a full time day job and spend their precious spare time working on this project to get it in the best shape possible.

A search feature - as explained multiple times - is not a trivial feature to add and we have little time to invest in such a big feature resulting in a lower priority for this.

Since this is an open-source project (MIT licensed) you - and many others - are free to contribute to this project.

I'm re-opening this issue to keep track of this feature request so the community can help us out.

niftylettuce commented 8 years ago

Awesome. Can one of us submit a PR for review then?!! :thumbsup: On Nov 3, 2015 9:32 AM, "Michiel De Mey" notifications@github.com wrote:

Currently, this is nothing more than a weekend project that suddenly got a lot of attention.

The unfortunate reality is that all of our core contributors have a full time day job and spend their precious spare time working on this project to get it in the best shape possible.

A search feature - as explained multiple times - is not a trivial feature to add and we have little time to invest in such a big feature resulting in a lower priority for this.

Since this is an open-source project (MIT licensed) you - and many others

  • are free to contribute to this project.

I'm re-opening this issue to keep track of this feature request so the community can help us out.

— Reply to this email directly or view it on GitHub https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-153372172.

bogas04 commented 8 years ago

I'm no designer but I think we can include a search button in <Header> which overlays a input above list items. A close button/back button would hide the search bar and restore initial look.

Excuse my paint skills

screen shot 2016-01-01 at 4 17 37 pm copy 2 screen shot 2016-01-01 at 4 17 37 pm copy