gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.44k stars 122 forks source link

fix #110 - restore dependency in yarn #112

Closed star114 closed 6 years ago

star114 commented 6 years ago

https://stackoverflow.com/questions/44343997/npm-notice-created-a-lockfile-as-package-lock-json-you-should-commit-this-file

MichielDeMey commented 6 years ago

This project currently uses Yarn as the dependency manager and currently has a lockfile for dependencies.

star114 commented 6 years ago

@MichielDeMey According to README.md, this project also uses npm. If it uses Yarn only, should we update README.md?

MichielDeMey commented 6 years ago

You're correct, we should reflect the use of Yarn in our README. Best to create a new issue for that or squash the commits of this PR. 👍

star114 commented 6 years ago

@MichielDeMey Thanks for your kind reply.

BTW, As I report the issue, #110, (not #111) something is wrong with Yarn on the current master branch. anitricks guided me to use npm instead of Yarn, and I resolved my issue and built completely. Don't you know any related problem in your developing environment?

I'll try to build it again using Yarn, but please have a look first.