search

gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.43k stars 123 forks source link

Incorrect styling of playlists #27

Open chrismessina opened 8 years ago

chrismessina commented 8 years ago

For some reason this playlist is appearing with strikethrough formatting.

screenshot_10_30_15__12_51_pm

gillesdemey commented 8 years ago

Hey @chrismessina, this happens when SoundCloud refuses to play back the audio. Some tracks have a form of DRM and do not allow them to be played in anything other than the official SoundCloud website or mobile apps.

MichielDeMey commented 8 years ago

We need a better way to convey that the tracks cannot be played. Any suggestions?

kokarn commented 8 years ago

Maybe gray-out with a hover tooltip?

On Fri, Oct 30, 2015 at 9:39 PM Michiel De Mey notifications@github.com wrote:

We need a better wat to convey that the tracks cannot be played. Any suggestions?

— Reply to this email directly or view it on GitHub https://github.com/gillesdemey/Cumulus/issues/27#issuecomment-152645951.

chrismessina commented 8 years ago

Is there any reason why you wouldn't just not show these tracks if they can't be played?

seppestas commented 8 years ago

Currently we only mark the song as not being playable when attempting to stream it fails. I am not sure, but maybe the embeddable_by or sharing property is useful to mark / filter out non-stream-able content in advance?

Either way, just hiding the content might cause some more "my feed is not the same as the one on the soundcloud website" confusion.

MichielDeMey commented 8 years ago

@Bitbored is correct.

We currently haven't found a way to know which songs can and which cannot be played beforehand. The error gets thrown when we actually try to play the song, so sorry for that.

Second, we debated about just removing the songs altogether in the past but eventually decided not to do this for UX reasons.

It's entirely possible - and even very likely - that you want to listen to an album which is DRM protected and cannot be played. Suddenly removing a lot of songs from the list will result in confusing behaviour to the user since they have no idea what's going on and why they were removed.

Also, it makes it easier in the code. ;)

Maybe we should grey them out, adding a small ? next to the songs so that when a user hovers over the ? they'll see a user-friendly message.

emhagman commented 8 years ago

May I suggest we just steal what SoundCloud does on Android? It is for "No Connection" but I imagine the same style can be applied.

Excuse my terrible photoshop skills:

This would be without the line through, etc.

felipeptx commented 8 years ago

Hi guys! Good to see you engaged on improving this nice app. Another good suggestion would be sort playlists in groups minimized rather than all of them opened. I'm not sure if there's another topic approaching this subject but this is the only SoundCloud client I've found with these features, but a bit uncomfortable because It's need to roll down through all playlists to find a song in the very bottom. I think the image can explain better than me. Please leave your ideas screen shot 2016-06-06 at 02 43 08

Cheers!

gillesdemey commented 7 years ago

@felipeptx Would you mind opening a separate issue for that so we can track it individually?