search

gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.43k stars 123 forks source link

Add volume controller #58

Closed v12 closed 8 years ago

v12 commented 8 years ago

Volume controller that handles both clicks and wheel (trackpad) movement when mouse is hovering the controller 😎

Closes #56

MichielDeMey commented 8 years ago

Nice PR, but I would like to see us use and skin the native range input element, that will allow us to read the value from the native element.

v12 commented 8 years ago

@MichielDeMey fair point, I absolutely forgot that input[type=range] exists 👍

MichielDeMey commented 8 years ago

Let's also persist the volume level (but not the "muted" state) to localStorage when the user closes the application, I believe that would improve UX a bit.

v12 commented 8 years ago

@MichielDeMey just pushed changes that implement all your suggestions 👍

v12 commented 8 years ago

Just wondering if anything prevents this PR from being merged? ☺️

MichielDeMey commented 8 years ago

Whoops, we totally lost track of this issue.

Thank you for your contribution!

fabianperez commented 8 years ago

Just came here looking for volume control support. Thanks for doing this! 🙌

gillesdemey commented 7 years ago

Released as v0.8.0

FoxxMD commented 7 years ago

Thanks for all the hard work!!