App stops playing when setting button is pressed

gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.

http://gillesdemey.github.io/Cumulus

MIT License

1.43k stars 123 forks source link

App stops playing when setting button is pressed #62

Open felipeptx opened 8 years ago

felipeptx commented 8 years ago

I really don't know why, but it simply stops playing when I click on settings button. When I close, it starts playing again… Has someone else gone through the same problem? cheers

felipeptx commented 8 years ago

screen shot 2016-06-08 at 16 11 10

gillesdemey commented 8 years ago

I can replicate this as well, I'll look into it.

mzdr commented 8 years ago

This is related to electron/issues/1854 since you are creating the Menu from the renderer process as well. Moving it to the main process will stop the audio from pausing. Unfortunately some other parts remain buggy like the progress bar for example.

This is going to need quite some ipc related refactoring… 😕

seppestas commented 8 years ago

Maybe we could replace the menu by a React component inside of the app?