search

gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.43k stars 123 forks source link

Does not work behind proxy #69

Open seventyeight opened 7 years ago

seventyeight commented 7 years ago

Cumulus ignores proxy settings from System Settings on Mac. How can i set them?

gillesdemey commented 7 years ago

Node's Request module seems to be ignoring system proxy settings, and managing proxies inside Cumulus is a complex task I'm not immediately willing to take up.

A proper solution could be moving the fetching of the tracks from the Node process to the render (browser) process but this requires a major refactor of the code base.

seventyeight commented 7 years ago

Okay, thanks for your explanation. With that i found a workaround: my proxy settings stored in environment variables too, so if i launch cumulus from the command line it just works.

gillesdemey commented 7 years ago

Maybe you can share what environment variables are picked up by Electron so others with a similar issue can use a proxy to connect? 🙂

v12 commented 7 years ago

Is it still the case? As far as I can see, audio is played in renderer process (code), thus proxy configuration and stuff should be handled by Electron. 😉