gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.44k stars 122 forks source link

Initialize window after window is created #75

Closed seppestas closed 7 years ago

seppestas commented 7 years ago

This prevents race conditions when mb.preloadWindow is set to false.

This would allow to disable window rendering if the user is not logged in yet.

gillesdemey commented 7 years ago

@seppestas Is this one still good to merge?

seppestas commented 7 years ago

Yes, it might a good idea to squash the commits though...

gillesdemey commented 7 years ago

A couple of remarks:

Based on this I've decided to close this issue and not merge it.