gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.44k stars 124 forks source link

New styles #83

Closed mirshko closed 7 years ago

mirshko commented 7 years ago

Should be a lot easier to compare changes now, sorry about that.

mirshko commented 7 years ago

@gillesdemey What do you think about the changes?

gillesdemey commented 7 years ago

I'll need some time to check out the branch, liking the sass variables so far!

mirshko commented 7 years ago

@gillesdemey Been about a week? No 🎲 ?

Hum4n01d commented 7 years ago

It doesn’t work for me… I just get a window

mirshko commented 7 years ago

@Hum4n01d did you build it right?

mirshko commented 7 years ago

Oops

Hum4n01d commented 7 years ago

No; I ran electron . Shouldn’t that work?

mirshko commented 7 years ago

You might need to npm install first

Hum4n01d commented 7 years ago

Maybe the problem is that I yarn installed instead…

mirshko commented 7 years ago

https://www.dropbox.com/s/cn1k3yd5240hkus/Screenshot%202017-02-06%2021.23.02.png?dl=0

It works fine for me when I packaged it.

mirshko commented 7 years ago

Yeah it uses npm, never worked with yarn before

Hum4n01d commented 7 years ago

Ah ok

Hum4n01d commented 7 years ago

Still doesn’t work though

Hum4n01d commented 7 years ago

I ran npm install and then electron . and got a blank Cumulus window and this in the console:

/Library/Caches/com.apple.xbs/Sources/AppleGVA/AppleGVA-10.1.5/Sources/Slices/Driver/AVD_loader.cpp: failed to get a service for display 1

mirshko commented 7 years ago

thats weird. All this branch edits is the styles. @gillesdemey ?

seppestas commented 7 years ago

Hey @Hum4n01d, this looks like a problem related to Electron/Chromium rather than Cumulus. Can you check if you can launch other Electron apps on your system?

What version of Electron are you using?

Hum4n01d commented 7 years ago

@seppestas Ok, I'll check when I get a chance

gillesdemey commented 7 years ago

I does sounds like something rather related to Electron; FWIW I can build it on my local system and the style changes shouldn't impact anything in particular.

Merging this for now and will create a new release — thanks for the hard work (and the patience) 👍

gillesdemey commented 7 years ago

Released as v0.10.0

Hum4n01d commented 7 years ago

Yay!

mirshko commented 7 years ago

Sweeeeeet! :D thanks @gillesdemey Glad you liked the update!

mirshko commented 7 years ago

Let me know if there is anything else I can help with!