gillesdemey / Cumulus

☁️ A SoundCloud player that lives in your menubar.
http://gillesdemey.github.io/Cumulus
MIT License
1.44k stars 124 forks source link

Corrupted Images #92

Closed franciosi closed 7 years ago

franciosi commented 7 years ago

When I download Cumulus-0.10.1.dmg or even Cumulus-0.10.0.dmg my Mac can not open it. It show a 'corrupted image' box. Why?

OSX 10.9.5, MacBook Air

gillesdemey commented 7 years ago

It looks like sindresorhus/create-dmg creates an ULFO DMG file (which uses lzfse compression), which requires at least MacOS 10.11

https://github.com/sindresorhus/create-dmg/blob/c5bd843d6ca3b60dbd5ea60cc8f7d1223d2b0b47/cli.js#L61

I'll see if I can land a patch to allow passing the DMG format so we can create DMG files using zlib compression.

https://github.com/sindresorhus/create-dmg/issues/8

gillesdemey commented 7 years ago

I've re-uploaded the latest binary with zlib compression, can you try it again?

franciosi commented 7 years ago

Perfect!!! Thank you!!

Amazing and simple software!!

On Thu, Apr 13, 2017 at 12:42 PM, Gilles De Mey notifications@github.com wrote:

I've re-uploaded the latest binary with zlib compression, can you try it again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gillesdemey/Cumulus/issues/92#issuecomment-293933295, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHirNsjZxaSlmbmCsEhSEjXeXpHluYJks5rvkJ9gaJpZM4M7dFT .

-- André Franciosi Diretor

Franciosi Consultoria Inteligência em Negócios, TI e Infraestrutura http://www.franciosi.info | @franciosi +55 51 9 9722 7685 [Mobile] +55 92 9 8178 6623 [Mobile]

gillesdemey commented 7 years ago

👍