search

gillesdemey / node-record-lpcm16

:microphone: Records a 16-bit signed-integer linear pulse modulation code encoded audio file.
ISC License
212 stars 59 forks source link

crashing after a while #15

Closed sce9sc closed 7 years ago

sce9sc commented 7 years ago

Change execa to spawn

gillesdemey commented 7 years ago

Cross referencing https://github.com/evancohen/sonus/issues/22

evancohen commented 7 years ago

Continuing the discussion from d655da9.

If it actually solves Windows issues then it sounds like cross-spawn would be the way to go 👍

Somewhat related question: Why do you need a PassThrough stream? It doesn't seem necessary. On super low-powered devices (Pi, CHIP, etc) it's additional overhead.

gillesdemey commented 7 years ago

Upon investigating it seems that cross-spawn isn't really solving any problems that are applicable to us.

gillesdemey commented 7 years ago

Somewhat related question: Why do you need a PassThrough stream? It doesn't seem necessary. On super low-powered devices (Pi, CHIP, etc) it's additional overhead.

I'll see if I can do something about that in the next release, will probably publish it as a minor version bump

gillesdemey commented 7 years ago

Published as 0.1.7

evancohen commented 7 years ago

Excellent! Thanks for the quick turn-around :)