gillesdemey / node-record-lpcm16

:microphone: Records a 16-bit signed-integer linear pulse modulation code encoded audio file.
ISC License
212 stars 59 forks source link

support pause and resume of audio #38

Closed evancohen closed 7 years ago

evancohen commented 7 years ago

This is a fix for #37. This instructs the child process to hide it's binary output.

Some other idea that I could use your input on:

gillesdemey commented 7 years ago

This looks awesome, just a few minor (non-blocking) concerns;

The API is 👌 since we are pausing and resuming and not recording silence.

We should also call cp.stdout.pause() and cp.stdout.resume() so we can use the streams internal isPaused() method to track the state of the recording.

On top of that, if you could add these methods to the README that would be 🤘

evancohen commented 7 years ago

Looks like you've implemented this in v1 #39! Closing this out.

Thalinda commented 4 years ago

so how to stop streaming i am trying to implement same but can't stop streaming stop and pause is not working