Self call points are miscalculated

gillessed / palantarot

Tarot score tracking and stats website.

2 stars 2 forks source link

Self call points are miscalculated #69

Open jonsyu1 opened 3 years ago

jonsyu1 commented 3 years ago

If the bidder calls themselves, they should win 4x the points. Instead they win 2x. tarot-self-call-bug

jonsyu1 commented 3 years ago

Initial thoughts: point calculation should not use multipliers and instead be computed using zero sum. This works for all player counts.

When the bidder loses:

Opposition wins base score
If partner exists, partner loses base score
Bidder loses (sum of opposition - partner)

jonsyu1 commented 3 years ago

This computation necessarily exists in multiple places because the results backend got it right and the online play frontend got it wrong. Ideally the results backend should expose an endpoint for scoring to avoid code duplication and make scoring consistent.