gilleswaeber / emoji-keyboard

Emoji Keyboard for Windows, allows to type emojis in any application using an onscreen keyboard.
MIT License
47 stars 4 forks source link

Add Recently Used Emojis + Positioning options #16

Closed gilleswaeber closed 1 year ago

gilleswaeber commented 1 year ago

To check before merging

Optionally

gilleswaeber commented 1 year ago

@robertwidfen I fixed some stuff, changed others. I would consider it ready to be merged (script.js not updated yet). Would you mind having a try? The main changes to the recent keyboard are:

robertwidfen commented 1 year ago

I checked out your "wip" and tried to compile to get script.js updated - but I am on a different machine now and had to setup nmp, tsc, and dependencies ... again - I am not sure if there is a problem with my setup 🤔 or wip is incomplete, but I get compile errors in script/layout.ts ... 🙄

But I really want to give it a try ... nice new stuff and fixes of my remnants from what I can tell from the log 😁

- script/layout.ts:115:81 - error TS2322: Type '1012' is not assignable to type 'SC'.

115 SC.CapsLock, 1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010, 1011, 1012,

    ~~~~

script/layout.ts:116:2 - error TS2322: Type '1002' is not assignable to type 'SC'.

116 SC.Shift, 1013, 1014, 1015, 1016, 1017, 1018, 1019, 1020, 1021, 1022, 1023, 1024

script/layout.ts:119:2 119 all: KeyCodesList;


    The expected type comes from property 'all' which is declared here on
type 'BaseLayout'

Am Di., 25. Apr. 2023 um 17:51 Uhr schrieb Gilles Waeber <
***@***.***>:

> @robertwidfen <https://github.com/robertwidfen> I fixed some stuff,
> changed others. I would consider it ready to be merged (script.js not
> updated yet). Would you mind having a try? The main changes to the recent
> keyboard are:
>
>    - right/shift click allows to set as favorite or remove
>    - score is displayed on hover when in recent kb
>    - typing in the recent keyboard does not count for the score
>    - the config file is saved only when the keyboard gets hidden
>    - letter keyboards are excluded (e.g. greek)
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/gilleswaeber/emoji-keyboard/pull/16#issuecomment-1522034466>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6FJ2NG7WSZ3UH2DML6ZHTLXC7XIFANCNFSM6AAAAAAWUWJS2Y>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
gilleswaeber commented 1 year ago

Hi, the error you got was caused by a Typescript update that made stricter checks for enum values. It looks like you run the user-installed typescript (tsc) and not the folder-installed typescript (yarn tsc/npm run tsc) which should work fine, except I was a version behind in this case. Thanks, this should now be fixed.