Extension and modification to provide compatibility with MS AD

gillg / OctoPrint-LDAP

Octoprint LDAP auth plugin

GNU Affero General Public License v3.0

26 stars 22 forks source link

Extension and modification to provide compatibility with MS AD #15

Closed BlackJaecky closed 2 years ago

BlackJaecky commented 3 years ago

Hi,

is added a few ldap and client settings to provide compatibility with MS AD. Also added a option to disable referrals, due to problems with MS AD with enabeld referrals. Bugfix: If no user can be found in the group MS AD returns as result a list where the first entry is None but not the complete list. Therefore check if dn is None in search result.

In addition, in the readme the link to the repo of battis is provided. Is that intentional? Have not changed that part.

Best

gillg commented 3 years ago

@battis have you an advice on this PR ? I know you already used it with an AD if I remember correctly.

battis commented 3 years ago

I can take a look in the next couple days. (I was on break last week, sorry!)