search

gilligan / data.these

data.these for javascript
4 stars 1 forks source link

adds fantasy-checks #1

Closed stoeffel closed 8 years ago

stoeffel commented 8 years ago

I created some tests to check if data.these is fantasy-land compliant. Don't know if you are interested in adding this specs, I was just curious and created them :smile: Feel free to close this PR without merging.

gilligan commented 8 years ago

@stoeffel thanks a lot ! I will try to have a look at the changes in the evening!

stoeffel commented 8 years ago

cool! let me know if I have to change anything.

stoeffel commented 8 years ago

Btw. It would be nice to link to the FL specs in the readme, if you decide to merge this.

gilligan commented 8 years ago

@stoeffel will do. thanks for this.

stoeffel commented 8 years ago

Awesome!

gilligan commented 8 years ago

@stoeffel aeuhrm.. next time please check npm run lint - i should have added that to the test script.

gilligan commented 8 years ago

@stoeffel Also fantasy-identities and fantasy-combinators are not being used so i will remove them from package.json. Also the fantasy test uses template strings even though the remaining code is not written in es6 yet - i just changed that.

stoeffel commented 8 years ago

arg sorry didn't see the lint task.