gilphilbert / jukestudio

A web-based tool to create title labels for jukeboxes
https://juke.studio
2 stars 1 forks source link

Label Coloring #2

Closed BeckyLanger closed 1 year ago

BeckyLanger commented 2 years ago

Good Morning! I am printing out multiple labels with different colors. It seems to work fine as long as I don't choose a color and request the artist be filled in. Once I choose that, it automatically fills in the artist red instead of whatever color I choose.

For example, I typed in 2 songs and choose diamond design, purple for the color, and for the artist portion to be filled and song to be white fill. I attached a few pictures.

20220220_084331 20220220_084321

gilphilbert commented 2 years ago

Thanks for reporting this! Yes, it seems like I had a bug there, I've fixed that in the app.

The app now respects your record-specific settings then falls back to the default design styles. If there's a colored background, it will be the correct color. Let me know if you have any further issues

altman65 commented 2 years ago

Hi ! When I try to change the background color to Green using the Candy Cane style, it doesn't seem to work... It keeps another color instead..

b251d084-3559-4ef4-9139-ec2e02d7a8c3_7

Thanks

gilphilbert commented 2 years ago

Ah, that seems somewhat related. Let me see what's going on and I'll fix this

gilphilbert commented 2 years ago

Oh dear - the "Candy Cane" design is only ever supposed to be green! I must have missed that when I made the changes above. Let me track down the issue and push a fix

altman65 commented 2 years ago

Hi, would you have any news for this issue ?

Thank you !

Rogerio

De : gilphilbert @.> Envoyé : mardi 22 mars 2022 05:04 À : gilphilbert/jukestudio @.> Cc : altman65 @.>; Comment @.> Objet : Re: [gilphilbert/jukestudio] Label Coloring (Issue #2)

Ah, that seems somewhat related. Let me see what's going on and I'll fix this

— Reply to this email directly, view it on GitHub https://github.com/gilphilbert/jukestudio/issues/2#issuecomment-1074701423 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNBDCGCIKPLN6B73TLKN4TVBFBDFANCNFSM5O4OI4CA . You are receiving this because you commented. https://github.com/notifications/beacon/ABNBDCDJK3VAVDCBEMRNT7LVBFBDFA5CNFSM5O4OI4CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIAHKI3Y.gif Message ID: @. @.> >

gilphilbert commented 2 years ago

Apologies, I've been moving house and have had very little time! It should be resolved now, please try and let me know if you still have problems.

altman65 commented 2 years ago

Thank you for your reply !

The colored background for title with the Candy Cane style still remains unchanged... Am I doing something wrong?

Best, Rogerio

De : gilphilbert @.> Envoyé : jeudi 31 mars 2022 09:24 À : gilphilbert/jukestudio @.> Cc : altman65 @.>; Comment @.> Objet : Re: [gilphilbert/jukestudio] Label Coloring (Issue #2)

Apologies, I've been moving house and have had very little time! It should be resolved now, please try and let me know if you still have problems. — Reply to this email directly, https://github.com/gilphilbert/jukestudio/issues/2#issuecomment-1084194066, or https://github.com/notifications/unsubscribe-auth/ABNBDCDESLRWOQYUCPDCDHDVCV HIRANCNFSM5O4OI4CA. You are receiving this because you commented.Message ID: @.***>

gilphilbert commented 2 years ago

Can you show me your settings in the app? I can't reproduce your issue, so I'm trying to work out what settings you have that are causing this. If you can show me the screen for the record and the screen for your design settings, and the PDF output like these:

design

record

label-misprint-full

Then I can see what's going on.

Note: I've just realized one candy cane is missing, so I'll fix that now.

altman65 commented 2 years ago

Hi, as you can see, the background color does not change with this style.

Thanks

De : gilphilbert @.> Envoyé : jeudi 31 mars 2022 19:29 À : gilphilbert/jukestudio @.> Cc : altman65 @.>; Comment @.> Objet : Re: [gilphilbert/jukestudio] Label Coloring (Issue #2)

Can you show me your settings in the app? I can't reproduce your issue, so I'm trying to work out what settings you have that are causing this. If you can show me the screen for the record and the screen for your design settings, like these:

https://user-images.githubusercontent.com/3300825/161114620-34a1aafb-1a15-4709-833f-062aa07ae8aa.png

https://user-images.githubusercontent.com/3300825/161114645-bd9d83d3-452d-4d47-a6e8-cdff146ac8fb.png

Then I can see what's going on.

— Reply to this email directly, view it on GitHub https://github.com/gilphilbert/jukestudio/issues/2#issuecomment-1084900215 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNBDCCUMZWSCE7YEEFGRUTVCXOGBANCNFSM5O4OI4CA . You are receiving this because you commented. https://github.com/notifications/beacon/ABNBDCCMXUPPKNTX3XXBQVLVCXOGBA5CNFSM5O4OI4CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOICVEG5Y.gif Message ID: @. @.> >

gilphilbert commented 2 years ago

Oh, are you saying you want to be able to select a different color (not green) for the Candy Cane style?

The labels on the application are designed to replicate the original strips exactly, using the original colors and styles. The Christmas styles (Holly and Candy Cane) are from real strips from the 50's and 60's that used specific greens and reds and the application reproduces those. As such, Holly only comes with a white background and red lines and Candy Cane only comes with a specific green background and red lines. The selection of different colors isn't "supposed" to work for these styles.

You can see an original label here that shows where the design comes from. I have some lingering around here but I can't find one right now: https://i.etsystatic.com/10223733/r/il/3b592b/2326556692/il_794xN.2326556692_3zgu.jpg