search

gilsdav / ngx-translate-router

Translate routes using ngx-translate
131 stars 43 forks source link

Update to angular 14 and fix angular breaking changes #127

Closed ruizmarc closed 2 years ago

ruizmarc commented 2 years ago

Hi!

I've just updated everything to Angular 14 and fixed all breaking changes.

I've tested the project with the demo project in the repo and my own project. Everything seems to work fine :)

Hope you can merge it!

PS: As there are breaking changes in angular router, this version cannot be backwards compatible with Angular 13 or previous. Anyone using Angular 13 should stick to localize router 4.

gilsdav commented 2 years ago

Thanks for this pull request, it looks great, just have to make some tests and I will publish it.

ruizmarc commented 2 years ago

Sounds great! Let me know if you need anything else from me ;)

ruizmarc commented 2 years ago

Hi @gilsdav, did you find any issue with the pull request preventing it to be merged? If you found any issue but you don’t have time to investigate more or fix it, I can have a look to it 🧐

gilsdav commented 2 years ago

Hello @ruizmarc, sorry I'm out of my country but I will pass it monday at night.