gilsdav / ngx-translate-router

Translate routes using ngx-translate
131 stars 43 forks source link

feat: inject TitleStrategy into router factory #133

Closed mstieranka closed 2 years ago

mstieranka commented 2 years ago

Fixes #129


The implementation is inspired by the way setupRouter() injects the TitleStrategy in the angular/router library, but it is modified to make sure it fits the architecture of this library.

I noticed that unit tests don't seem to work, but I tested this build of the library in an app where we currently use the modified library mentioned in #129 and everything is working as intended, including the case where the default TitleStrategy is used.

gilsdav commented 2 years ago

Published in version 5.1.0