gilsdav / ngx-translate-router

Translate routes using ngx-translate
131 stars 43 forks source link

Angular 15 Localize Router Not Working #138

Closed yavuzgunay closed 1 year ago

yavuzgunay commented 1 year ago

I updated my project to Angular 15. After updating the localize router did not work. Project give _proto not found error at file localized-router.ts.

Celtian commented 1 year ago

Same for me: image

It seems to be working in 15.0.0 but not in 15.0.2

gilsdav commented 1 year ago

Tkank's for the precision. This version will probably be a big deal because of the new API's. This library has to work like previously (with module) and with the new standalone API.

daco commented 1 year ago

I can confirm: it's working in 15.0.0 and not in 15.0.2, which seems strange to me because patch updates aren't suppose to break things, right? Is there a fix planned, or can I help in any way?

BojanKogoj commented 1 year ago

Having the same problem, though throws different exception for the same line (ff). I'm on 15.0.0 though

slika

ruizmarc commented 1 year ago

It seems we have received an explanation from the angular Team https://github.com/angular/angular/issues/48421. Which is the plan @gilsdav? Can we make it work for Angular 15? I have contributed a few times to this library and I'm happy to help if there is a path to follow.

gilsdav commented 1 year ago

Hello @ruizmarc, thanks for all tout contributions. We known that we use private apis that can have breaking changes but we din't find an other way to acheve what the library do.

First think to do is to check all New changes to the RouterModule and apply it in this library. As explained by Angular Team, they don't use constructor anymor for injection so firstly we have adapt ours and cross fingers.

BojanKogoj commented 1 year ago

I think I've fixed it, will open PR soon.

gilsdav commented 1 year ago

Let's try this RC version: 6.0.0-rc1

BojanKogoj commented 1 year ago

I tested 6.0.0-rc1 on 4 different projects, no issues so far.

gilsdav commented 1 year ago

Version 6.0.0-rc2 is out with some cleaning. If everything is ok I will publish it as latest version.

daco commented 1 year ago

I'm testing 6.0.0-rc2, so far no issues

gilsdav commented 1 year ago

Version 6.0.0 released