Angular 15 - Githubissues

gilsdav / ngx-translate-router

Translate routes using ngx-translate

131 stars 43 forks source link

Angular 15 #139

Closed BojanKogoj closed 1 year ago

BojanKogoj commented 1 year ago

Changes:

Updated to Angular 15.0.3
Removed constructor parameters from Router
Moved configLoader and transitions from Router to NavigationTransition
Removed relativeLinkResolution; it was depricated and only corrected exists now

This is a fix for 15.0.3+, it will probably not work with 15.0.2 and below.

Closes #138

BojanKogoj commented 1 year ago

Not that this PR does not migrate to usage of inject or remove setupRouter as Angular Router has done.

gilsdav commented 1 year ago

Thank's for your amazing investigation ! As I can see, we can now remove the setupRouter and give LocalizedRouter as provider. One thing less to maintain.

duxor commented 1 year ago

Looks great :+1:

@gilsdav Could you release it (the RC version is also ok for now)?

gilsdav commented 1 year ago

@duxor @BojanKogoj You can try the RC version: 6.0.0-rc1

duxor commented 1 year ago

@gilsdav works as expected for me, thanks :+1: