search

gilsdav / ngx-translate-router

Translate routes using ngx-translate
131 stars 43 forks source link

Add SSR to demo Project #158

Closed ruizmarc closed 8 months ago

ruizmarc commented 10 months ago

Testing changes in SSR for this package requires to setup a new project with SSR and publishing a new version of the package or linking your local one and reproducing all test cases, which is not so convenient for development…

I think that integrating SSR to the demo project it will make things easier to everyone that wants to contribute as now it is much easier to develop in SSR as angular provides a development SSR server with live reload, so no extra setup is required to test it.

By the way, during SSR development, I also tested the new Standalone API, as I'm forking from that branch, and it seems to work fine in both browser and SSR.

jemys89 commented 8 months ago

Hello! Oooh Thanks!!

ruizmarc commented 8 months ago

@gilsdav is there anything I can do for you to get standalone api merged and this PR merged?

gilsdav commented 8 months ago

@gilsdav is there anything I can do for you to get standalone api merged and this PR merged?

Hello @ruizmarc thank's ! I think the last thing to do is add this new API into documentation (readme).