search

giltene / wrk2

A constant throughput, correct latency recording variant of wrk
Apache License 2.0
4.23k stars 381 forks source link

Make wrk2 arm compatible #110

Open tbbharaj opened 3 years ago

tbbharaj commented 3 years ago

Trying to compile wrk2 on arm, generates following error:

lj_arch.h:279:2: error: #error "No target architecture defined"
 #error "No target architecture defined"

Upgraded LuaJIT to 2.1 to make wrk2 arm compatible. Also added few minor changes to hdr_histogram.c script.c wrk.c to make it compile

tbbharaj commented 3 years ago

Wanted to followup on this PR to get wrk2 compiled on aarch64

raguiar9080 commented 2 years ago

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

tbbharaj commented 2 years ago

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

Are you able to clone this repo/branch?

raguiar9080 commented 2 years ago

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

Are you able to clone this repo/branch?

Just to give you a point of situation, I can and did clone the branch, but then ran into several issues while trying to build it (openssl include files followed by a malformed Mach-o file).

I just went and ran a linux container to install normally since my purpose is just perform some tests. Thanks for the help 👍

tbbharaj commented 2 years ago

Wanted to followup on this PR. Happy to address any feedbacks/reviews

tbbharaj commented 2 years ago

Wanted to followup on this PR, would love to see wrk2 supporting arm

raguiar9080 commented 2 years ago

I've since moved away from this. I solved my issue by simply creating a docker container and doing things from the inside so I can't really provide any further feedback.

Best of luck 🙏

sebpop commented 2 years ago

Hi, who can review and merge this patch? With this patch I can build and use wrk2 on arm64.

Thanks!

orefalo commented 2 years ago

thank you. sorry to ask, I am a newbie. I see no configure script. and when I run make, i get

Apple clang version 13.1.6 (clang-1316.0.21.2.3) Target: arm64-apple-darwin21.4.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin

i did brew install gcc but then it's not picked up

orefalo commented 2 years ago

found this guy https://github.com/AppsFlyer/wrk3

AGSaidi commented 2 years ago

any hope to get this reviewed and merged?

outsinre commented 1 year ago

For those, who would like to run wrk2 on Apple M1, please refer to https://github.com/outsinre/homebrew-wrk2.

odidev commented 1 year ago

Team, Can we please merge this PR to make wrk2 compatible with arm64.

RamaMalladiAWS commented 1 year ago

Checking again... Can this patch be merged? Thanks.

orefalo commented 1 year ago

I switched to oha - https://github.com/hatoo/oha

recommended