giltene / wrk2

A constant throughput, correct latency recording variant of wrk
Apache License 2.0
4.28k stars 395 forks source link

command wrk -> wrk2 #68

Closed whyboris closed 1 year ago

whyboris commented 5 years ago

Clarifying README.md 👍

jonrichards commented 5 years ago

Hi @whyboris, how do you have wkr2 installed? If you compile it from source you end up with a binary named wrk, not wrk2. See the instructions from the wiki for what I'm referring to: https://github.com/giltene/wrk2/wiki/Installing-wrk2-on-Linux.

whyboris commented 5 years ago

It's been over 1/2 year since I used it -- I remember running the command with wrk2 on my Mac 🤷‍♂ I'm pretty sure I installed it with these instructions: https://github.com/giltene/wrk2/wiki/Installing-wrk2-on-Mac

brew tap jabley/homebrew-wrk2
brew install --HEAD wrk2
jonrichards commented 5 years ago

@giltene I think this would ultimately depend on if there is a goal for wrk2 to be upstreamed into wrk one day, or if that's not likely to happen. I could see benefit in having the binary be named wrk2 to more easily exist alongside wrk if upstreaming wasn't probable.