Stopping all threads, doesn't stop WRK

giltene / wrk2

A constant throughput, correct latency recording variant of wrk

Apache License 2.0

4.28k stars 395 forks source link

Stopping all threads, doesn't stop WRK #98

Closed Subtalime closed 4 years ago

Subtalime commented 4 years ago

I know, this has been raised also in the original WRK from "wg" (https://github.com/wg/wrk). However, there seems to be no activity there and I am actually using this repo anyway. I would expect WRK to end when all Threads had been sent a "stop". Though WRK continues until the "run-time" has been reached. This invalidates all calculations of performance, since Threads haven't been processing. Any chance this could be looked at?

Subtalime commented 4 years ago

ignore, it does it... wrk.thread:stop()