search

gilzoide / godot-dockable-container

Dockable/tiling UI panels Container addon for Godot
Creative Commons Zero v1.0 Universal
186 stars 19 forks source link

updated to godot 4.0 (alpha1) #7

Closed Gamemap closed 2 years ago

Gamemap commented 2 years ago

~ Edit: wrong PR

I have updated your code to Godot 4 (alpha 1). I have a problem with the EditorInspectorPlugin. It doesn't make a new entry in the Inspector Panel. Maybe you can help me. (There is no hurry)

All other things seem to be working. Gamemap

OverloadedOrama commented 2 years ago

I think it may be better if this PR was targeted for the godot-4.0 branch instead of main. Right now this plugin is used in Godot 3.x and changing the codebase to work for 4.0 might cause confusion. It might be better if we waited for Godot 4.0-stable before making changes to the main branch. Unless if the Asset Library has a way to make different assets for different versions of Godot? I'm not sure how it works.

Gamemap commented 2 years ago

Sorry, I forgot to set the branch correctly. It should be corrected now.

gilzoide commented 2 years ago

Hi @Gamemap, nice one!

~ Edit: wrong PR

What does that mean?

Hey, I see lots of cache files from the editor in paths like .godot/..., I think they shouldn't be in git at all. Just add .godot/ to the .gitignore file and remove the files.

I'm also seeing some commits here that are already in main. I'll bump the godot-4.0 branch to the same commit as main, so we can have a clearer look at your changes.

Also, @OverloadedOrama I entered the Asset Library and see some plugins with duplicated entries, one ending with (G4), maybe we could do such a thing for having both versions there. I don't really know either, but might be a solution.

Gamemap commented 2 years ago

What does that mean?

I had prepared two Pr's for different Godot projects and accidentally copied the wrong text into this Pr.

Gamemap commented 2 years ago

I am currently on vacation and will continue on Tuesday.

gilzoide commented 2 years ago

I had prepared two Pr's for different Godot projects and accidentally copied the wrong text into this Pr.

Oh, got it. I think you don't need to explain this kind of edit, don't worry ^^

I am currently on vacation and will continue on Tuesday.

I'm also traveling and will only be able to give this PR greater care next week, I hope you don't mind.

Gamemap commented 2 years ago

Sadly Github dosn't update the commit view. Please tell me if I should create a new pr, but for now you can see my changes here: https://github.com/gilzoide/godot-dockable-container/pull/7/files/c0c631d27178923d28d8631b0116f4efad2cb360..12bf132c1b27bd191c714b9f72f8c68ac21d1ab5

gilzoide commented 2 years ago

Yeah, that's really weird. It's still showing some old commits, even though I bumped the godot-4.0 branch to where main was. Feel free to try opening a new PR first to see if it gets the right commits. If it does, we can close this one and continue there.

I still need to download Godot 4.0 to test your patch, but will do =]

gilzoide commented 2 years ago

Sorry about the delay. I just tried opening your fork in Godot 4 (to be more specific, I'm using v4.0.alpha2.official [79077e6c1] in a Linux x86_64 machine) and the test scene had an error at TestScene.gd line 19. Apparently BaseButton.pressed got renamed to BaseButton.button_pressed. Also dragging panels to split the containers did not work. The preview of the rectangle appears, but dropping wasn't accepted, so the layout continued the same after releasing the mouse.

Were you able to run the test scene and drag/split panels around correctly in your fork?

Gamemap commented 2 years ago

Apparently BaseButton.pressed got renamed to BaseButton.button_pressed.

Thank you, I will update this.

Also dragging panels to split the containers did not work. The preview of the rectangle appears, but dropping wasn't accepted, so the layout continued the same after releasing the mouse.

I have this problem too. The EditorInspectorPlugin does not make a new entry in the Inspector Panel for the new Label Resource. I don't know how to fix this. (I didn't understand it with Godot 3.x either) Maybe you can help me with that.

Feel free to try opening a new PR first to see if it gets the right commits. If it does, we can close this one and continue there.

I didn't created a new PR because I had to close this one first to do a new one, and I didn't have enough time to do this last week.

Gamemap commented 2 years ago

It is working. Thank you very much! If it would be ok for you I would close this PR to continue with the correct commits in a new one.

gilzoide commented 2 years ago

Ok, I'll just close the PR then, feel free to open a new one. I hope it works, not being able to see the latest commits is really annoying.

Gamemap commented 2 years ago

Superseded by #8.