search

gilzoide / unity-flex-ui

Flexbox layout support for Unity UI using the Yoga layout engine
The Unlicense
80 stars 5 forks source link

The Flexbox layout failed to refresh upon toggling the GameObject's active state. #18

Closed timurproko closed 2 months ago

timurproko commented 3 months ago

Actual Result The Flexbox layout fails to update when toggling the active state of the Game Object. It only updates when selecting another Game Object with the Flexbox script. However, upon entering Game Mode, the Flexbox reverts to its previous state. Please refer to the video recording to observe this behavior. https://github.com/gilzoide/unity-flex-ui/assets/80062439/1ca5ab6d-3ec6-4345-bb1a-8b5416bb40c3

Step To Reproduce

  1. Create Canvas with Flexbox no Wrap Column
  2. Add 3 Pannels with Flexbox Script
  3. Hide one Pannel observe that the flexbox not updated
  4. Select another pannel observe that the flexbox is updated
  5. Enter Game mode observe that flexbox get back to the state where the 3d pannel is hidden but flexbox isn't updated

Expected Result The Flexbox updates when I toggle the active state of the Game Object and remains consistent in both the Scene and Game views.

Visual References Configured Flexbox 01 One Pannel toggled to be hidden in Inspector 02 Flexbox is updating in Scene View when the other pannel is selected 03 Flexbox updating back to previous state in when enter Game Mode 04

gilzoide commented 2 months ago

Hey @timurproko, thanks for the report! I think I was able to fix this bug in branch bugfix/inactive-objects-handling, can you please test it?

timurproko commented 2 months ago

Thanks for reaching me out. I will try to test, I will get back to you soon.

Regards, Timur Prokopiev +38 (050) 641 55 93

On Mon, 22 Apr 2024 at 01:04, Gil Barbosa Reis @.***> wrote:

Hey @timurproko https://github.com/timurproko, thanks for the report! I think I was able to fix this bug in branch bugfix/inactive-objects-handling, can you please test it?

— Reply to this email directly, view it on GitHub https://github.com/gilzoide/unity-flex-ui/issues/18#issuecomment-2068216433, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATC2PZ2BEEC65NN6B6F73MLY6QZVTAVCNFSM6AAAAABF4J3SZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGIYTMNBTGM . You are receiving this because you were mentioned.Message ID: @.***>

timurproko commented 2 months ago

Hi Gil Barbosa, I have tested the plugin and it works well. Thanks for your hard work.

On Mon, Apr 22, 2024 at 6:09 PM Timur Prokopiev @.***> wrote:

Thanks for reaching me out. I will try to test, I will get back to you soon.

Regards, Timur Prokopiev +38 (050) 641 55 93

On Mon, 22 Apr 2024 at 01:04, Gil Barbosa Reis @.***> wrote:

Hey @timurproko https://github.com/timurproko, thanks for the report! I think I was able to fix this bug in branch bugfix/inactive-objects-handling, can you please test it?

— Reply to this email directly, view it on GitHub https://github.com/gilzoide/unity-flex-ui/issues/18#issuecomment-2068216433, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATC2PZ2BEEC65NN6B6F73MLY6QZVTAVCNFSM6AAAAABF4J3SZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGIYTMNBTGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Regards, Timur Prokopiev +38 (050) 641 55 93

gilzoide commented 2 months ago

Awesome! Thanks for the report and for testing the fix @timurproko =D Version 1.1.1 is released with this fix!