search

gimite / web-socket-js

HTML5 Web Socket implementation powered by Flash
BSD 3-Clause "New" or "Revised" License
2.73k stars 489 forks source link

Allow expressInstall.swf for Flash versions < 10 #110

Open andrewhavens opened 12 years ago

andrewhavens commented 12 years ago

I was having a hard time debugging why I couldn't get web-socket-js to work. Finally when I enabled debugging I realized that I had an older version of Flash installed. After looking through the code it looks like web-socket-js doesn't have a way to specify that you want to allow expressInstall for easy upgrades. Could this be improved so that we can specify a location of the expressInstall.swf if we want to allow this option?

gimite commented 12 years ago

I didn't know about expressInstall.swf. What does it do? If you send a pull request adding support for it, I may pull it if it looks useful and not very complicated to integrate. BTW web-socket-js outputs error on console.error for known errors, including when Flash Player is < 10. So please check JavaScript console of the browser when you encounter any issues.

andrewhavens commented 12 years ago

expressInstall.swf is a feature of Flash v6+ that swfobject.js supports. It provides an easy way for users to upgrade to the latest version of flash if they don't have the required version (in this case Flash 10+). Flash will prompt the user to upgrade and automatically install it.

I did eventually find the WEB_SOCKET_DEBUG = true.

I will see if I can add this feature and submit it as a pull request.

gimite commented 12 years ago

expressInstall.swf is a feature of Flash v6+ that swfobject.js supports. It provides an easy way for users to upgrade to the latest version of flash if they don't have the required version (in this case Flash 10+). Flash will prompt the user to upgrade and automatically install it.

I see. Seems useful.

I did eventually find the WEB_SOCKET_DEBUG = true.

Error messages to console.error should be output regardless of WEB_SOCKET_DEBUG.