search

gimite / web-socket-js

HTML5 Web Socket implementation powered by Flash
BSD 3-Clause "New" or "Revised" License
2.73k stars 489 forks source link

retVal variable pollutes global scope #46

Closed vsviridov closed 13 years ago

vsviridov commented 13 years ago

I'm not sure if this is by design, but there's a bunch of places with retVal variable is not prefixed with var, so it ends up in global scope.

Cross-posted from Socket.IO's tracker, since it uses web-socket-js as a shim.

gimite commented 13 years ago

I guess it's simply a bug. FABridge is third-party library, so I'm not exactly sure, though.

gimite commented 13 years ago

Note that FABridge is external library, so I'd like to keep the change minimum. e.g. I want to keep the original code style, and will fix only obvious bugs such as dropping "var".

gimite commented 13 years ago

This bug is now obsolete because we stopped using FABridge.